Fix issue 6472 that exhibited a few crashing bugs in dart2js.

Fix issue 6472 that exhibited a few crashing bugs in dart2js.
Committed: https://code.google.com/p/dart/source/detail?r=14461

[ngeoffray, 2012-11-02 10:47:15]

On 2012/11/02 10:46:33, ngeoffray wrote:

Err, fix bug 6472, not r14278.

[kasperl, 2012-11-02 11:09:40]

LGTM.

https://codereview.chromium.org/11361059/diff/1/lib/compiler/implementation/s...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/11361059/diff/1/lib/compiler/implementation/s...
lib/compiler/implementation/ssa/optimize.dart:150: // If the replacement
instruction does not know its
Add newline before the comment here.

[ngeoffray, 2012-11-02 11:15:31]

Thanks Kasper

https://codereview.chromium.org/11361059/diff/1/lib/compiler/implementation/s...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/11361059/diff/1/lib/compiler/implementation/s...
lib/compiler/implementation/ssa/optimize.dart:150: // If the replacement
instruction does not know its
On 2012/11/02 11:09:41, kasperl wrote:
> Add newline before the comment here.

Done.

[ahe, 2012-11-05 08:33:32]

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
File lib/compiler/implementation/universe/partial_type_tree.dart (right):

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
lib/compiler/implementation/universe/partial_type_tree.dart:67: if
(type.element.isTypedef()) return compiler.functionClass;
I think this deserves a TODO. You're throwing away information.

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
File lib/compiler/implementation/universe/universe.dart (right):

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
lib/compiler/implementation/universe/universe.dart:425: ClassElement self =
receiverType.element;
Doesn't this fail in checked mode?

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
lib/compiler/implementation/universe/universe.dart:433: if (!self.isTypedef() &&
!self.isInterface() && self.isSubclassOf(other)) {
I think it would be better with a positive test, such as: self.isClass(). Also,
I'm not sure the value of testing for isInterface as classes can be used as
interfaces as well.

https://codereview.chromium.org/11361059/diff/6001/tests/language/checked_nul...
File tests/language/checked_null_test.dart (right):

https://codereview.chromium.org/11361059/diff/6001/tests/language/checked_nul...
tests/language/checked_null_test.dart:9: // of [a] was inferred to be
[Comparator] or null;
Did you mean [b] was inferred to be [Comparator]?

https://codereview.chromium.org/11361059/diff/6001/tests/language/checked_nul...
tests/language/checked_null_test.dart:14: Expect.throws(bar, (e) => e is
NullPointerException);
You cannot be sure to get a NullPointerException on all platforms.

[ngeoffray, 2012-11-05 10:51:03]

Thanks Peter for the comments. New CL uploaded:
https://codereview.chromium.org/11361093/.

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
File lib/compiler/implementation/universe/partial_type_tree.dart (right):

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
lib/compiler/implementation/universe/partial_type_tree.dart:67: if
(type.element.isTypedef()) return compiler.functionClass;
On 2012/11/05 08:33:32, ahe wrote:
> I think this deserves a TODO. You're throwing away information.

Done.

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
File lib/compiler/implementation/universe/universe.dart (right):

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
lib/compiler/implementation/universe/universe.dart:425: ClassElement self =
receiverType.element;
On 2012/11/05 08:33:32, ahe wrote:
> Doesn't this fail in checked mode?

Good catch. The test I wrote was not complete.

https://codereview.chromium.org/11361059/diff/6001/lib/compiler/implementatio...
lib/compiler/implementation/universe/universe.dart:433: if (!self.isTypedef() &&
!self.isInterface() && self.isSubclassOf(other)) {
On 2012/11/05 08:33:32, ahe wrote:
> I think it would be better with a positive test, such as: self.isClass().
Also,
> I'm not sure the value of testing for isInterface as classes can be used as
> interfaces as well.

Done.

https://codereview.chromium.org/11361059/diff/6001/tests/language/checked_nul...
File tests/language/checked_null_test.dart (right):

https://codereview.chromium.org/11361059/diff/6001/tests/language/checked_nul...
tests/language/checked_null_test.dart:9: // of [a] was inferred to be
[Comparator] or null;
On 2012/11/05 08:33:32, ahe wrote:
> Did you mean [b] was inferred to be [Comparator]?

No [a]. It was a bug.

https://codereview.chromium.org/11361059/diff/6001/tests/language/checked_nul...
tests/language/checked_null_test.dart:14: Expect.throws(bar, (e) => e is
NullPointerException);
On 2012/11/05 08:33:32, ahe wrote:
> You cannot be sure to get a NullPointerException on all platforms.

I removed the is check.