Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/compiler/implementation/universe/partial_type_tree.dart

Issue 11361059: Fix issue 6472 that exhibited a few crashing bugs in dart2js. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/optimize.dart ('k') | lib/compiler/implementation/universe/universe.dart » ('j') | lib/compiler/implementation/universe/universe.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/universe/partial_type_tree.dart
===================================================================
--- lib/compiler/implementation/universe/partial_type_tree.dart (revision 14453)
+++ lib/compiler/implementation/universe/partial_type_tree.dart (working copy)
@@ -63,7 +63,9 @@
// TODO(kasperl): Move this to the Selector class?
ClassElement selectorType(Selector selector) {
DartType type = selector.receiverType;
- return (type != null) ? type.element : compiler.objectClass;
+ if (type == null) return compiler.objectClass;
+ if (type.element.isTypedef()) return compiler.functionClass;
ahe 2012/11/05 08:33:32 I think this deserves a TODO. You're throwing away
ngeoffray 2012/11/05 10:51:03 Done.
+ return type.element;
}
/**
« no previous file with comments | « lib/compiler/implementation/ssa/optimize.dart ('k') | lib/compiler/implementation/universe/universe.dart » ('j') | lib/compiler/implementation/universe/universe.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698