Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: tests/language/checked_null_test.dart

Issue 11361059: Fix issue 6472 that exhibited a few crashing bugs in dart2js. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/checked_null_test.dart
===================================================================
--- tests/language/checked_null_test.dart (revision 0)
+++ tests/language/checked_null_test.dart (revision 0)
@@ -0,0 +1,23 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+class A {
+ Map a;
+ Comparator b;
+ // This code exhibited a bug in dart2js checked mode, where the type
+ // of [a] was inferred to be [Comparator] or null;
ahe 2012/11/05 08:33:32 Did you mean [b] was inferred to be [Comparator]?
ngeoffray 2012/11/05 10:51:03 No [a]. It was a bug.
+ A() : b = null, a = null;
+}
+
+main() {
+ Expect.throws(bar, (e) => e is NullPointerException);
ahe 2012/11/05 08:33:32 You cannot be sure to get a NullPointerException o
ngeoffray 2012/11/05 10:51:03 I removed the is check.
+}
+
+bar() {
+ // We would create a typed selector for the call to foo, where the
+ // receiver type is a typedef. Some code in the dart2js backend were
+ // not dealing correctly with typedefs and lead the compiler to
+ // crash.
+ new A().a.foo();
+}

Powered by Google App Engine
This is Rietveld 408576698