Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1135933003: Get the omnibox to show up again. Sky's changes from yesterday removed the window manager interface… (Closed)

Created:
5 years, 7 months ago by Ben Goodger (Google)
Modified:
5 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get the omnibox to show up again. Sky's changes from yesterday removed the window manager interface. This is a temporary interface to allow the omnibox app to ask the browser app to place its window. R=sadrul@chromium.org BUG= Committed: https://crrev.com/28b82f5492169f8daa053a7008c19fe69b634064 Cr-Commit-Position: refs/heads/master@{#330241}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -28 lines) Patch
M mandoline/ui/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/browser/browser.h View 4 chunks +15 lines, -4 lines 0 comments Download
M mandoline/ui/browser/browser.cc View 1 4 chunks +25 lines, -19 lines 0 comments Download
A + mandoline/ui/browser/view_embedder.mojom View 1 chunk +5 lines, -4 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
5 years, 7 months ago (2015-05-15 21:36:04 UTC) #1
sadrul
The android build failure looks related (probably needs to use a more explicit version of ...
5 years, 7 months ago (2015-05-15 22:14:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135933003/20001
5 years, 7 months ago (2015-05-15 23:29:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-16 00:16:09 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:29:35 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28b82f5492169f8daa053a7008c19fe69b634064
Cr-Commit-Position: refs/heads/master@{#330241}

Powered by Google App Engine
This is Rietveld 408576698