Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: mandoline/ui/omnibox/omnibox_impl.cc

Issue 1135933003: Get the omnibox to show up again. Sky's changes from yesterday removed the window manager interface… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mandoline/ui/omnibox/omnibox_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/ui/omnibox/omnibox_impl.cc
diff --git a/mandoline/ui/omnibox/omnibox_impl.cc b/mandoline/ui/omnibox/omnibox_impl.cc
index 75a3d605de48e826813b4dcaa331d199fefa4397..b310c03273d759ab73d3afb7cb2205a981262675 100644
--- a/mandoline/ui/omnibox/omnibox_impl.cc
+++ b/mandoline/ui/omnibox/omnibox_impl.cc
@@ -39,6 +39,7 @@ bool OmniboxImpl::ConfigureIncomingConnection(
mojo::ApplicationConnection* connection) {
connection->AddService<Omnibox>(this);
connection->AddService(view_manager_client_factory_.get());
+ connection->ConnectToService(&view_embedder_);
return true;
}
@@ -134,7 +135,8 @@ void OmniboxImpl::SetClient(OmniboxClientPtr client) {
void OmniboxImpl::ShowForURL(const mojo::String& url) {
url_ = url;
- // TODO: get embedding working.
+
+ view_embedder_->Embed("mojo:omnibox", nullptr, nullptr);
}
} // namespace mandoline
« no previous file with comments | « mandoline/ui/omnibox/omnibox_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698