mandoline/ui/omnibox/omnibox_impl.h - Issue 1135933003: Get the omnibox to show up again. Sky's changes from yesterday removed the window manager interface…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/ui/omnibox/omnibox_impl.h

Issue 1135933003: Get the omnibox to show up again. Sky's changes from yesterday removed the window manager interface… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mandoline/ui/omnibox/omnibox_impl.h

diff --git a/mandoline/ui/omnibox/omnibox_impl.h b/mandoline/ui/omnibox/omnibox_impl.h

index 0d59c769ea9242ee382e8a3326f512ee7ad2d983..2c3e97ab7ef44dc633d34f68034f2dd236282971 100644

--- a/mandoline/ui/omnibox/omnibox_impl.h

+++ b/mandoline/ui/omnibox/omnibox_impl.h

@@ -7,6 +7,7 @@

#include "components/view_manager/public/cpp/view_manager_delegate.h"

#include "mandoline/ui/browser/omnibox.mojom.h"

+#include "mandoline/ui/browser/view_embedder.mojom.h"

#include "mojo/application/public/cpp/application_delegate.h"

#include "mojo/application/public/cpp/interface_factory.h"

#include "mojo/common/weak_binding_set.h"

@@ -68,6 +69,7 @@ class OmniboxImpl : public mojo::ApplicationDelegate,

views::Textfield* edit_;

mojo::WeakBindingSet<Omnibox> bindings_;

scoped_ptr<mojo::ViewManagerClientFactory> view_manager_client_factory_;

+ ViewEmbedderPtr view_embedder_;

DISALLOW_COPY_AND_ASSIGN(OmniboxImpl);

};

« no previous file with comments | « mandoline/ui/browser/view_embedder.mojom ('k') | mandoline/ui/omnibox/omnibox_impl.cc » ('j') | no next file with comments »