Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1135233003: X87: Reapply "Resolve references to "this" the same way as normal variables"" (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reapply "Resolve references to "this" the same way as normal variables"" port 1efc1e4f7a3d30d5225e9d5cb2585cad7cb17099 (r28458). original commit message: This reapplies https://codereview.chromium.org/1136073002, along with the followups: Remove Scope::scope_uses_this_ flag https://codereview.chromium.org/1128963005 and PPC: Resolve references to "this" the same way as normal variables https://codereview.chromium.org/1134073003 BUG= Committed: https://crrev.com/dec2619a187623d7dafa0e390cef18efe0f6f653 Cr-Commit-Position: refs/heads/master@{#28469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 7 months ago (2015-05-19 09:21:00 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-19 09:33:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135233003/1
5 years, 7 months ago (2015-05-19 09:33:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 10:05:41 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 10:05:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dec2619a187623d7dafa0e390cef18efe0f6f653
Cr-Commit-Position: refs/heads/master@{#28469}

Powered by Google App Engine
This is Rietveld 408576698