[Password manager tests automation] Fix automated tests runner.

[Password manager tests automation] Fix automated tests runner.

Fix error introduced while adressing comments in
https://codereview.chromium.org/1089383002/

BUG=369521
R=vabr@chromium.org

Committed: https://crrev.com/f0d41ff457719264be0af4071ff3c05e2e8e13d1
Cr-Commit-Position: refs/heads/master@{#330501}

[melandory, 2015-05-18 14:31:02]

Hi Vaclav,


review this CL, please.


Thanks in advance.

[melandory, 2015-05-18 14:31:04]

Hi Vaclav,


review this CL, please.


Thanks in advance.

[melandory, 2015-05-18 14:34:11]

On 2015/05/18 14:31:04, melandory wrote:
> Hi Vaclav,
> 
> 
> review this CL, please.
> 
> 
> Thanks in advance.

Hm, sorry for second message. I've sent it in wrong CL.

[vabr (Chromium), 2015-05-18 16:28:27]

Thanks, Tanja.

This LGTM with 2 comments.

Cheers,
Vaclav

https://codereview.chromium.org/1134843005/diff/1/components/test/data/passwo...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/1134843005/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:134: "Get %s
as timeout state instead of expected %s" %
grammar: Get -> Got

https://codereview.chromium.org/1134843005/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:135:
(timeout.state, timeout.EXECUTED))
Printing the EXECUTED constant looks a bit strange. Perhaps more useful would be
to identify the enum type:
"Got %d as timeout state (see stopit.ThreadingTimeout for the meaning of the
number)"
?

[melandory, 2015-05-19 08:07:25]

https://codereview.chromium.org/1134843005/diff/1/components/test/data/passwo...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/1134843005/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:134: "Get %s
as timeout state instead of expected %s" %
On 2015/05/18 16:28:27, vabr (Chromium) wrote:
> grammar: Get -> Got

Done.

https://codereview.chromium.org/1134843005/diff/1/components/test/data/passwo...
components/test/data/password_manager/automated_tests/run_tests.py:135:
(timeout.state, timeout.EXECUTED))
On 2015/05/18 16:28:27, vabr (Chromium) wrote:
> Printing the EXECUTED constant looks a bit strange. Perhaps more useful would
be
> to identify the enum type:
> "Got %d as timeout state (see stopit.ThreadingTimeout for the meaning of the
> number)"
> ?

Done.

[melandory, 2015-05-19 08:07:38]

The CQ bit was checked by melandory@chromium.org

[melandory, 2015-05-19 08:07:39]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1134843005/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-05-19 08:08:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134843005/20001

[commit-bot: I haz the power, 2015-05-19 10:12:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-19 10:12:57]

Patchset 2 (id:??) landed as
https://crrev.com/f0d41ff457719264be0af4071ff3c05e2e8e13d1
Cr-Commit-Position: refs/heads/master@{#330501}