[Password manager tests automation] Fix automated tests runner.

components/test/data/password_manager/automated_tests/run_tests.py

 # -*- coding: utf-8 -*-
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Encapsulates running tests defined in tests.py.
 
 Running this script requires passing --config-path with a path to a config file
 of the following structure:
 
@@ skipping 111 matching lines @@
     try:
       with stopit.ThreadingTimeout(100) as timeout:
         logger.log(SCRIPT_DEBUG,
                    "Run test with parameters: %s %s %s %s %s %s",
                    config.chrome_path, config.chromedriver_path,
                    profile_path, config.passwords_path,
                    website, test_case)
         result = tests.RunTest(config.chrome_path, config.chromedriver_path,
                                profile_path, config.passwords_path,
                                website, test_case)[0]
-      if timeout != timeout.EXECUTED:
-        result =  (website, test_case, False, "Timeout")
+      if timeout.state != timeout.EXECUTED:
+        result =  (website, test_case, False,
+                   "Get %s as timeout state instead of expected %s" %

[vabr (Chromium), 2015/05/18 16:28:27]

grammar: Get -> Got

[melandory, 2015/05/19 08:07:25]

Done.

+                       (timeout.state, timeout.EXECUTED))

[vabr (Chromium), 2015/05/18 16:28:27]

Printing the EXECUTED constant looks a bit strange. Perhaps more useful would be
to identify the enum type:
"Got %d as timeout state (see stopit.ThreadingTimeout for the meaning of the
number)"
?

[melandory, 2015/05/19 08:07:25]

Done.

       _, _, success, _ = result
       if success:
         return result
     except Exception as e:
       result = (website, test_case, False, e)
   return result
 
 
 def RunTests(config_path):
   """Runs automated tests.
@@ skipping 31 matching lines @@
 def main():
   parser = argparse.ArgumentParser()
   parser.add_argument("config_path", metavar="N",
                       help="Path to the config.ini file.")
   args = parser.parse_args()
   RunTests(args.config_path)
 
 
 if __name__ == "__main__":
   main()