Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: components/test/data/password_manager/automated_tests/run_tests.py

Issue 1134843005: [Password manager tests automation] Fix automated tests runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test/data/password_manager/automated_tests/run_tests.py
diff --git a/components/test/data/password_manager/automated_tests/run_tests.py b/components/test/data/password_manager/automated_tests/run_tests.py
index 7a054a5444b1a1a15785f441577243456f65c379..f64a26179317915403655cb32a9c19120adb8cb7 100644
--- a/components/test/data/password_manager/automated_tests/run_tests.py
+++ b/components/test/data/password_manager/automated_tests/run_tests.py
@@ -129,8 +129,10 @@ def RunTestCaseOnWebsite((website, test_case, config)):
result = tests.RunTest(config.chrome_path, config.chromedriver_path,
profile_path, config.passwords_path,
website, test_case)[0]
- if timeout != timeout.EXECUTED:
- result = (website, test_case, False, "Timeout")
+ if timeout.state != timeout.EXECUTED:
+ result = (website, test_case, False,
+ "Got %d as timeout state (see stopit.ThreadingTimeout for"
+ "the meaning of the number)" % timeout.state)
_, _, success, _ = result
if success:
return result
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698