Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11348335: Revert 170514 (Closed)

Created:
8 years ago by Alexander Potapenko
Modified:
8 years ago
Reviewers:
bryeung
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 170514 > Bluetooth API Permission Dialogs. > > This CL introduces two new concepts: > - API permissions that cannot be found in the manifest (and therefore > need not be in the optional permissions section to be optionally > requested) > - optional API permission requests that have associated data > > BUG=119473 > TBR=sky@chromium.org > > > Review URL: https://chromiumcodereview.appspot.com/11413099 TBR=bryeung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -444 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers.cc View 4 chunks +7 lines, -36 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_manifest_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_manifest_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission_set.cc View 1 chunk +1 line, -8 lines 0 comments Download
D chrome/common/extensions/permissions/bluetooth_device_permission.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/common/extensions/permissions/bluetooth_device_permission.cc View 1 chunk +0 lines, -220 lines 0 comments Download
M chrome/common/extensions/permissions/permission_message.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/renderer/resources/extensions/permissions_custom_bindings.js View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
8 years ago (2012-11-30 23:52:08 UTC) #1
Alexander Potapenko
TBR Reverted because of a memory leak on the Heapcheck waterfall, http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/22423: Leak of 64 ...
8 years ago (2012-11-30 23:58:28 UTC) #2
bryeung
8 years ago (2012-12-03 15:36:58 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698