Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5324)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.cc

Issue 11348335: Revert 170514 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/permissions/permissions_api.cc
===================================================================
--- chrome/browser/extensions/api/permissions/permissions_api.cc (revision 170599)
+++ chrome/browser/extensions/api/permissions/permissions_api.cc (working copy)
@@ -169,16 +169,9 @@
}
}
- // Filter out permissions that do not need to be listed in the optional
- // section of the manifest.
- scoped_refptr<extensions::PermissionSet>
- manifest_required_requested_permissions =
- PermissionSet::ExcludeNotInManifestPermissions(
- requested_permissions_.get());
-
// The requested permissions must be defined as optional in the manifest.
if (!GetExtension()->optional_permission_set()->Contains(
- *manifest_required_requested_permissions)) {
+ *requested_permissions_)) {
error_ = kNotInOptionalPermissionsError;
results_ = Request::Results::Create(false);
return false;

Powered by Google App Engine
This is Rietveld 408576698