Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4613)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 11348335: Revert 170514 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/permissions/permission_set.cc ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
===================================================================
--- chrome/common/extensions/permissions/permission_set_unittest.cc (revision 170599)
+++ chrome/common/extensions/permissions/permission_set_unittest.cc (working copy)
@@ -735,14 +735,6 @@
i != permissions.end(); ++i) {
const APIPermissionInfo* permission_info = i->info();
EXPECT_TRUE(permission_info != NULL);
-
- // Always skip permissions that cannot be in the manifest.
- const APIPermission* permission = permission_info->CreateAPIPermission();
- if (permission->ManifestEntryForbidden()) {
- continue;
- }
- delete permission;
-
if (skip.count(i->id())) {
EXPECT_EQ(PermissionMessage::kNone, permission_info->message_id())
<< "unexpected message_id for " << permission_info->name();
« no previous file with comments | « chrome/common/extensions/permissions/permission_set.cc ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698