Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1134453003: Merge 194421 "Avoid transiently creating disallowed elements whe..." (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), darktears, gyuyoung2, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Merge 194421 "Avoid transiently creating disallowed elements whe..." > Avoid transiently creating disallowed elements when building <use> trees > > When building a shadow tree for a <use>, a direct reference to a > "disallowed" element would cause the element to first be inserted before > buildShadowTree() noticed it's disallowed and returns false, so it's > removed again. > This transient mutation could take place while computing an animation > update, if a CSS property was being animated and the layout tree/style > was dirty. > Avoid the insert-remove sequence by checking if the initial target is > disallowed up-front. This matches how it's done in the general subtree > building case inside buildShadowTree(). > > BUG=478549 > > Review URL: https://codereview.chromium.org/1105873002 TBR=fs@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + LayoutTests/svg/custom/use-referencing-animation-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/custom/use-referencing-animation-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
fs
5 years, 7 months ago (2015-05-07 08:03:34 UTC) #1
fs
5 years, 7 months ago (2015-05-07 08:03:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r195031.

Powered by Google App Engine
This is Rietveld 408576698