Source/core/svg/SVGUseElement.cpp - Issue 1134453003: Merge 194421 "Avoid transiently creating disallowed elements whe..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGUseElement.cpp

Issue 1134453003: Merge 194421 "Avoid transiently creating disallowed elements whe..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/2357/

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGUseElement.cpp

===================================================================

--- Source/core/svg/SVGUseElement.cpp (revision 195030)

+++ Source/core/svg/SVGUseElement.cpp (working copy)

@@ -392,7 +392,7 @@

// Do not allow self-referencing.

// 'target' may be null, if it's a non SVG namespaced element.

- if (!target || target == this)

+ if (!target || target == this || isDisallowedElement(target))

return;

// Set up root SVG element in shadow tree.

« no previous file with comments | « LayoutTests/svg/custom/use-referencing-animation-crash-expected.txt ('k') | no next file » | no next file with comments »