Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1105873002: Avoid transiently creating disallowed elements when building <use> trees (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
Reviewers:
pdr., kouhei (in TOK)
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, krit, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, Mike Lawther (Google), pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, Steve Block, Timothy Loh
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid transiently creating disallowed elements when building <use> trees When building a shadow tree for a <use>, a direct reference to a "disallowed" element would cause the element to first be inserted before buildShadowTree() noticed it's disallowed and returns false, so it's removed again. This transient mutation could take place while computing an animation update, if a CSS property was being animated and the layout tree/style was dirty. Avoid the insert-remove sequence by checking if the initial target is disallowed up-front. This matches how it's done in the general subtree building case inside buildShadowTree(). BUG=478549 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
A LayoutTests/svg/custom/use-referencing-animation-crash.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/use-referencing-animation-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 8 months ago (2015-04-24 12:07:00 UTC) #2
pdr.
lgtm LGTM
5 years, 8 months ago (2015-04-24 22:35:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105873002/1
5 years, 8 months ago (2015-04-24 22:36:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194421
5 years, 8 months ago (2015-04-25 01:10:51 UTC) #6
kouhei (in TOK)
5 years, 8 months ago (2015-04-25 03:45:43 UTC) #7
Message was sent while issue was closed.
lgtm Thanks!

Powered by Google App Engine
This is Rietveld 408576698