Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 11343028: Revert 164652 - speculative revert - this change may have caused print dialog test failures on XP. (Closed)

Created:
8 years, 1 month ago by Sergey Ulanov
Modified:
8 years, 1 month ago
CC:
chromium-reviews, marja+watch_chromium.org, sadrul, tfarina, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 164652 - speculative revert - this change may have caused print dialog test failures on XP. Re-vamped the entire window auto positioning logic As long as the user did not move / resize the window: A single visible window (browser / app) on the screen will always be centered. When a second visible (browser / app) window joins in, both will be pushed into opposite corners. When more windows get piled up, they go every time into the opposite side of the currently active window. When the user has resized / moved a window, it will be treated as a visible (browser / app) window, but it will not get moved - the others will however. Addressing bug: Moving last remaining tabbed window back into screen center BUG=153431, 150879, 153302 TEST=unit-tests & visual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164352 Review URL: https://chromiumcodereview.appspot.com/11085053 TBR=skuhne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -688 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/property_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/property_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_properties.h View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/wm/window_properties.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/window_util.h View 2 chunks +6 lines, -19 lines 0 comments Download
M ash/wm/window_util.cc View 4 chunks +5 lines, -24 lines 0 comments Download
D ash/wm/workspace/auto_window_management.h View 1 chunk +0 lines, -20 lines 0 comments Download
D ash/wm/workspace/auto_window_management.cc View 1 chunk +0 lines, -178 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager2_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager2.cc View 3 chunks +3 lines, -14 lines 0 comments Download
M ash/wm/workspace/workspace_manager2_unittest.cc View 1 chunk +0 lines, -285 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/prefs/pref_service_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +0 lines, -12 lines 0 comments Download
MM chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_aura.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_aura.cc View 4 chunks +1 line, -20 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 8 chunks +1 line, -34 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 5 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sergey Ulanov
8 years, 1 month ago (2012-10-29 23:05:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698