Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: ash/wm/workspace/workspace_manager2.cc

Issue 11343028: Revert 164652 - speculative revert - this change may have caused print dialog test failures on XP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/workspace/workspace_manager2.cc
===================================================================
--- ash/wm/workspace/workspace_manager2.cc (revision 164764)
+++ ash/wm/workspace/workspace_manager2.cc (working copy)
@@ -17,7 +17,6 @@
#include "ash/wm/window_animations.h"
#include "ash/wm/window_properties.h"
#include "ash/wm/window_util.h"
-#include "ash/wm/workspace/auto_window_management.h"
#include "ash/wm/workspace/desktop_background_fade_controller.h"
#include "ash/wm/workspace/workspace_animations.h"
#include "ash/wm/workspace/workspace_layout_manager2.h"
@@ -594,14 +593,10 @@
// to the workspace.
if (workspace == active_workspace_)
UpdateShelfVisibility();
-
- RearrangeVisibleWindowOnShow(child);
}
void WorkspaceManager2::OnWillRemoveWindowFromWorkspace(Workspace2* workspace,
Window* child) {
- if (child->TargetVisibility())
- RearrangeVisibleWindowOnHideOrRemove(child);
child->ClearProperty(kWorkspaceKey);
}
@@ -614,16 +609,10 @@
void WorkspaceManager2::OnWorkspaceChildWindowVisibilityChanged(
Workspace2* workspace,
Window* child) {
- if (workspace->ShouldMoveToPending()) {
+ if (workspace->ShouldMoveToPending())
MoveWorkspaceToPendingOrDelete(workspace, NULL, SWITCH_VISIBILITY_CHANGED);
- } else {
- if (child->TargetVisibility())
- RearrangeVisibleWindowOnShow(child);
- else
- RearrangeVisibleWindowOnHideOrRemove(child);
- if (workspace == active_workspace_)
- UpdateShelfVisibility();
- }
+ else if (workspace == active_workspace_)
+ UpdateShelfVisibility();
}
void WorkspaceManager2::OnWorkspaceWindowChildBoundsChanged(
« no previous file with comments | « ash/wm/workspace/workspace_layout_manager2_unittest.cc ('k') | ash/wm/workspace/workspace_manager2_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698