Add HTTP certificate report URL with Finch gate

Add HTTP certificate report URL with Finch gate

This will allow us to keep sending reports over HTTPS until the server
can handle encrypted reports over HTTP.

BUG=461590
Committed: https://crrev.com/6e57659ebc88b63ecde5554962dccab65060b5cc
Cr-Commit-Position: refs/heads/master@{#329955}

[estark, 2015-05-13 05:22:08]

estark@chromium.org changed reviewers:
+ felt@chromium.org

[estark, 2015-05-13 05:22:09]

felt: could you please take a quick look before I send to a //c/b/net OWNER?

meacer: FYI

[felt, 2015-05-13 20:24:12]

https://codereview.chromium.org/1134283003/diff/1/chrome/browser/net/certific...
File chrome/browser/net/certificate_error_reporter.cc (right):

https://codereview.chromium.org/1134283003/diff/1/chrome/browser/net/certific...
chrome/browser/net/certificate_error_reporter.cc:130: const char
kHttpCertificateUploadExperiment[] =
are these in the shared namespace for the unit test?

[estark, 2015-05-13 20:25:45]

https://codereview.chromium.org/1134283003/diff/1/chrome/browser/net/certific...
File chrome/browser/net/certificate_error_reporter.cc (right):

https://codereview.chromium.org/1134283003/diff/1/chrome/browser/net/certific...
chrome/browser/net/certificate_error_reporter.cc:130: const char
kHttpCertificateUploadExperiment[] =
On 2015/05/13 20:24:12, felt wrote:
> are these in the shared namespace for the unit test?

Yes. Should I put a comment saying so?

[felt, 2015-05-13 21:03:35]

lgtm

https://codereview.chromium.org/1134283003/diff/1/chrome/browser/net/certific...
File chrome/browser/net/certificate_error_reporter.cc (right):

https://codereview.chromium.org/1134283003/diff/1/chrome/browser/net/certific...
chrome/browser/net/certificate_error_reporter.cc:130: const char
kHttpCertificateUploadExperiment[] =
On 2015/05/13 20:25:45, estark wrote:
> On 2015/05/13 20:24:12, felt wrote:
> > are these in the shared namespace for the unit test?
> 
> Yes. Should I put a comment saying so?

No, just htinking that normally they would be in an anonymous namespace but the
unit test makes sense.

[estark, 2015-05-13 21:08:43]

estark@chromium.org changed reviewers:
+ eroman@chromium.org, mattm@chromium.org

[estark, 2015-05-13 21:08:43]

Thanks felt.

eroman: could you please take a look at //chrome/browser/net?

mattm: could you please take a look at //chrome/browser/safe_browsing?

[mattm, 2015-05-14 03:06:58]

lgtm

[estark, 2015-05-14 17:12:00]

The CQ bit was checked by estark@chromium.org

[estark, 2015-05-14 17:12:07]

The CQ bit was unchecked by estark@chromium.org

[estark, 2015-05-14 21:23:41]

I'm going to go ahead and commit this before eroman gets to it, because I want
to get it in for M44 and it's a short week for me. (I didn't realize that mattm
was also a //c/b/net OWNER when I was assigning reviewers.)

eroman: please feel free to revert if you have any objections.

[estark, 2015-05-14 21:24:05]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2015-05-14 21:25:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134283003/1

[commit-bot: I haz the power, 2015-05-14 21:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 21:30:48]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[estark, 2015-05-14 21:36:26]

The CQ bit was checked by estark@chromium.org

[estark, 2015-05-14 21:36:27]

The patchset sent to the CQ was uploaded after l-g-t-m from felt@chromium.org,
mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/1134283003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-05-14 21:37:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134283003/20001

[eroman, 2015-05-14 22:23:22]

Was out sick yesterday, taking a look now!

[eroman, 2015-05-14 22:25:18]

lgtm

[estark, 2015-05-14 22:26:42]

On 2015/05/14 22:25:18, eroman wrote:
> lgtm

Thanks eroman!

[commit-bot: I haz the power, 2015-05-14 22:32:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-14 22:33:40]

Patchset 2 (id:??) landed as
https://crrev.com/6e57659ebc88b63ecde5554962dccab65060b5cc
Cr-Commit-Position: refs/heads/master@{#329955}