Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5843)

Unified Diff: chrome/browser/net/certificate_error_reporter.cc

Issue 1134283003: Add HTTP certificate report URL with Finch gate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/certificate_error_reporter.cc
diff --git a/chrome/browser/net/certificate_error_reporter.cc b/chrome/browser/net/certificate_error_reporter.cc
index c1f15914001244b9ebfb3fb563ea800e3d11f863..6d0c66c387aac5d27dfc5c5db60577edf6ea6029 100644
--- a/chrome/browser/net/certificate_error_reporter.cc
+++ b/chrome/browser/net/certificate_error_reporter.cc
@@ -7,6 +7,7 @@
#include <set>
#include "base/logging.h"
+#include "base/metrics/field_trial.h"
#include "chrome/browser/net/encrypted_cert_logger.pb.h"
#if defined(USE_OPENSSL)
@@ -84,6 +85,12 @@ bool EncryptSerializedReport(
namespace chrome_browser_net {
+// Constants for the Finch trial that controls whether the
+// CertificateErrorReporter supports HTTP uploads.
+const char kHttpCertificateUploadExperiment[] =
+ "ReportCertificateErrorsOverHttp";
+const char kHttpCertificateUploadGroup[] = "UploadReportsOverHttp";
+
CertificateErrorReporter::CertificateErrorReporter(
net::URLRequestContext* request_context,
const GURL& upload_url,
@@ -174,7 +181,8 @@ scoped_ptr<net::URLRequest> CertificateErrorReporter::CreateURLRequest(
bool CertificateErrorReporter::IsHttpUploadUrlSupported() {
#if defined(USE_OPENSSL)
- return true;
+ return base::FieldTrialList::FindFullName(kHttpCertificateUploadExperiment) ==
+ kHttpCertificateUploadGroup;
#else
return false;
#endif
« no previous file with comments | « chrome/browser/net/certificate_error_reporter.h ('k') | chrome/browser/net/certificate_error_reporter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698