Add HTTP certificate report URL with Finch gate

chrome/browser/net/certificate_error_reporter.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/certificate_error_reporter.h"
 
 #include <set>
 
 #include "base/logging.h"
+#include "base/metrics/field_trial.h"
 #include "base/stl_util.h"
 #include "base/time/time.h"
 #include "chrome/browser/net/cert_logger.pb.h"
 
 #if defined(USE_OPENSSL)
 #include "crypto/aead_openssl.h"
 #endif
 
 #include "crypto/curve25519.h"
 #include "crypto/hkdf.h"
@@ skipping 97 matching lines @@
     report->add_cert_error(
         CertLoggerRequest::ERR_CERT_UNABLE_TO_CHECK_REVOCATION);
   if (cert_status & net::CERT_STATUS_NO_REVOCATION_MECHANISM)
     report->add_cert_error(CertLoggerRequest::ERR_CERT_NO_REVOCATION_MECHANISM);
 }
 
 }  // namespace
 
 namespace chrome_browser_net {
 
+// Constants for the Finch trial that controls whether the
+// CertificateErrorReporter supports HTTP uploads.
+const char kHttpCertificateUploadExperiment[] =

[felt, 2015/05/13 20:24:12]

are these in the shared namespace for the unit test?

[estark, 2015/05/13 20:25:45]

Yes. Should I put a comment saying so?

[felt, 2015/05/13 21:03:34]

No, just htinking that normally they would be in an anonymous namespace but the
unit test makes sense.

+    "ReportCertificateErrorsOverHttp";
+const char kHttpCertificateUploadGroup[] = "UploadReportsOverHttp";
+
 CertificateErrorReporter::CertificateErrorReporter(
     net::URLRequestContext* request_context,
     const GURL& upload_url,
     CookiesPreference cookies_preference)
     : CertificateErrorReporter(request_context,
                                upload_url,
                                cookies_preference,
                                kServerPublicKey,
                                kServerPublicKeyVersion) {
 }
@@ skipping 75 matching lines @@
       context->CreateRequest(upload_url_, net::DEFAULT_PRIORITY, this);
   if (cookies_preference_ != SEND_COOKIES) {
     request->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                           net::LOAD_DO_NOT_SAVE_COOKIES);
   }
   return request.Pass();
 }
 
 bool CertificateErrorReporter::IsHttpUploadUrlSupported() {
 #if defined(USE_OPENSSL)
-  return true;
+  return base::FieldTrialList::FindFullName(kHttpCertificateUploadExperiment) ==
+         kHttpCertificateUploadGroup;
 #else
   return false;
 #endif
 }
 
 // Used only by tests.
 #if defined(USE_OPENSSL)
 bool CertificateErrorReporter::DecryptCertificateErrorReport(
     const uint8 server_private_key[32],
     const EncryptedCertLoggerRequest& encrypted_report,
@@ skipping 74 matching lines @@
 }
 
 void CertificateErrorReporter::RequestComplete(net::URLRequest* request) {
   std::set<net::URLRequest*>::iterator i = inflight_requests_.find(request);
   DCHECK(i != inflight_requests_.end());
   scoped_ptr<net::URLRequest> url_request(*i);
   inflight_requests_.erase(i);
 }
 
 }  // namespace chrome_browser_net