Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1134163002: Catch Exception for Intent.parseUri instead of URISyntaxException (Closed)

Created:
5 years, 7 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 7 months ago
Reviewers:
Ted C, jbudorick, Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch Exception for Intent.parseUri instead of URISyntaxException Intent.parseUri can throw other excpetions like NumberFormatException. So we need to catch Exception to avoid crash. BUG=484336 Committed: https://crrev.com/bf271f140b3e7cec2926e9a24c2f687a39b1cacd Cr-Commit-Position: refs/heads/master@{#329482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 6 chunks +7 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Jaekyun Seok (inactive)
jbudorick@, please review this CL. BTW, do you know how to run findbug against this ...
5 years, 7 months ago (2015-05-12 01:49:26 UTC) #2
jbudorick
On 2015/05/12 01:49:26, Jaekyun Seok wrote: > jbudorick@, please review this CL. > > BTW, ...
5 years, 7 months ago (2015-05-12 01:54:52 UTC) #3
jbudorick
On 2015/05/12 01:54:52, jbudorick wrote: > On 2015/05/12 01:49:26, Jaekyun Seok wrote: > > jbudorick@, ...
5 years, 7 months ago (2015-05-12 01:55:43 UTC) #4
Jaekyun Seok (inactive)
On 2015/05/12 01:55:43, jbudorick wrote: > On 2015/05/12 01:54:52, jbudorick wrote: > > On 2015/05/12 ...
5 years, 7 months ago (2015-05-12 02:50:26 UTC) #5
Jaekyun Seok (inactive)
torne@ and tedchoc@, please review this CL. The original CL (https://codereview.chromium.org/1132473004/) was reverted due to ...
5 years, 7 months ago (2015-05-12 02:53:14 UTC) #7
Torne
lgtm
5 years, 7 months ago (2015-05-12 10:26:37 UTC) #8
Ted C
lgtm
5 years, 7 months ago (2015-05-12 20:40:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134163002/1
5 years, 7 months ago (2015-05-12 20:46:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 20:53:55 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 20:54:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf271f140b3e7cec2926e9a24c2f687a39b1cacd
Cr-Commit-Position: refs/heads/master@{#329482}

Powered by Google App Engine
This is Rietveld 408576698