Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1715)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

Issue 1134163002: Catch Exception for Intent.parseUri instead of URISyntaxException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
index 55465259094dc289490af1425982c5c285195a7e..4427533bcaceb72d256983e725332d0cc37b547a 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
@@ -9,21 +9,19 @@ import android.content.ActivityNotFoundException;
import android.content.Context;
import android.content.Intent;
import android.provider.Browser;
-import android.util.Log;
import android.view.KeyEvent;
import android.view.View;
import android.webkit.URLUtil;
import android.webkit.WebChromeClient;
import android.widget.FrameLayout;
+import org.chromium.base.Log;
import org.chromium.content.browser.ContentVideoViewClient;
import org.chromium.content.browser.ContentViewClient;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content.browser.SelectActionMode;
import org.chromium.content.browser.SelectActionModeCallback.ActionHandler;
-import java.net.URISyntaxException;
-
/**
* ContentViewClient implementation for WebView
*/
@@ -62,8 +60,8 @@ public class AwContentViewClient extends ContentViewClient implements ContentVid
// Perform generic parsing of the URI to turn it into an Intent.
try {
intent = Intent.parseUri(contentUrl, Intent.URI_INTENT_SCHEME);
- } catch (URISyntaxException ex) {
- Log.w(TAG, "Bad URI " + contentUrl + ": " + ex.getMessage());
+ } catch (Exception ex) {
+ Log.w(TAG, "Bad URI " + contentUrl, ex);
return;
}
// Sanitize the Intent, ensuring web pages can not bypass browser
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698