Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java

Issue 1134163002: Catch Exception for Intent.parseUri instead of URISyntaxException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java
index 0972aeec2b732750710d9d0fbc1b14cae0e8e782..4eba43e57f7bf9a32afa20a534bb2317fcd4212e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java
@@ -23,16 +23,17 @@ import android.widget.ScrollView;
import android.widget.TextView;
import org.chromium.base.CalledByNative;
+import org.chromium.base.Log;
import org.chromium.chrome.R;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.WebContentsObserver;
-import java.net.URISyntaxException;
-
/**
* Java side of Android implementation of the website settings UI.
*/
public class ConnectionInfoPopup implements OnClickListener {
+ private static final String TAG = "ConnectionInfoPopup";
+
private static final String HELP_URL =
"http://www.google.com/support/chrome/bin/answer.py?answer=95617";
private static final int DESCRIPTION_TEXT_SIZE_SP = 12;
@@ -212,8 +213,9 @@ public class ConnectionInfoPopup implements OnClickListener {
i.putExtra(Browser.EXTRA_CREATE_NEW_TAB, true);
i.putExtra(Browser.EXTRA_APPLICATION_ID, mContext.getPackageName());
mContext.startActivity(i);
- } catch (URISyntaxException ex) {
+ } catch (Exception ex) {
// Do nothing intentionally.
+ Log.w(TAG, "Bad URI " + mLinkUrl, ex);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698