Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1134103002: Revert of Handles AX role for time element. (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
CC:
blink-reviews, je_julie, nektarios, dmazzoni, dglazkov+blink, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Handles AX role for time element. (patchset #2 id:20001 of https://codereview.chromium.org/1123313004/) Reason for revert: This is causing a reliable failure in the chromevox_unittests on the Linu ChromeOS Tests (1) bot: https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/13831 (and is also blocking the Blink roll because of the failure) Original issue's description: > Handles AX role for time element. > > This patch adds InputTimeRole and makes it be used for Input element > with time type. In order to handle Time element for AX, the current > TimeRole is used. > > BUG=480861 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195168 TBR=dmazzoni@chromium.org,je_julie.kim@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480861 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M LayoutTests/accessibility/element-role-mapping-focusable.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/accessibility/element-role-mapping-focusable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
Created Revert of Handles AX role for time element.
5 years, 7 months ago (2015-05-11 17:14:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134103002/1
5 years, 7 months ago (2015-05-11 17:14:53 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 17:15:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195188

Powered by Google App Engine
This is Rietveld 408576698