Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: Source/modules/accessibility/AXLayoutObject.cpp

Issue 1134103002: Revert of Handles AX role for time element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 624 matching lines...) Expand 10 before | Expand all | Expand 10 after
635 635
636 if (roleValue() == MathRole) 636 if (roleValue() == MathRole)
637 return false; 637 return false;
638 638
639 if (roleValue() == MeterRole) 639 if (roleValue() == MeterRole)
640 return false; 640 return false;
641 641
642 if (roleValue() == RubyRole) 642 if (roleValue() == RubyRole)
643 return false; 643 return false;
644 644
645 if (roleValue() == TimeRole)
646 return false;
647
648 // if this element has aria attributes on it, it should not be ignored. 645 // if this element has aria attributes on it, it should not be ignored.
649 if (supportsARIAAttributes()) 646 if (supportsARIAAttributes())
650 return false; 647 return false;
651 648
652 // <span> tags are inline tags and not meant to convey information if they h ave no other aria 649 // <span> tags are inline tags and not meant to convey information if they h ave no other aria
653 // information on them. If we don't ignore them, they may emit signals expec ted to come from 650 // information on them. If we don't ignore them, they may emit signals expec ted to come from
654 // their parent. In addition, because included spans are GroupRole objects, and GroupRole 651 // their parent. In addition, because included spans are GroupRole objects, and GroupRole
655 // objects are often containers with meaningful information, the inclusion o f a span can have 652 // objects are often containers with meaningful information, the inclusion o f a span can have
656 // the side effect of causing the immediate parent accessible to be ignored. This is especially 653 // the side effect of causing the immediate parent accessible to be ignored. This is especially
657 // problematic for platforms which have distinct roles for textual block ele ments. 654 // problematic for platforms which have distinct roles for textual block ele ments.
(...skipping 1740 matching lines...) Expand 10 before | Expand all | Expand 10 after
2398 if (label && label->layoutObject()) { 2395 if (label && label->layoutObject()) {
2399 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2396 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2400 result.unite(labelRect); 2397 result.unite(labelRect);
2401 } 2398 }
2402 } 2399 }
2403 2400
2404 return result; 2401 return result;
2405 } 2402 }
2406 2403
2407 } // namespace blink 2404 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/accessibility/element-role-mapping-focusable-expected.txt ('k') | Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698