Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1134003009: media: Use mojo::StrongBinding in mojo media services. (Closed)

Created:
5 years, 7 months ago by xhwang
Modified:
5 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Use mojo::StrongBinding in mojo media services. BUG=489756 TEST=Mojo media services still working in html_viewer and chrome browser. Committed: https://crrev.com/9d04333fe1022f892eb483709cba1b2adc4ce977 Cr-Commit-Position: refs/heads/master@{#330790}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -21 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.h View 2 chunks +6 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.h View 2 chunks +6 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 3 chunks +6 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
xhwang
sandersd: Since you are interested in mojo... PTAL! jam: Please OWNERS review content/browser/frame_host/render_frame_host_impl.cc
5 years, 7 months ago (2015-05-19 22:52:38 UTC) #2
sandersd (OOO until July 31)
lgtm
5 years, 7 months ago (2015-05-19 23:08:17 UTC) #3
jam
lgtm https://codereview.chromium.org/1134003009/diff/1/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/1134003009/diff/1/content/browser/frame_host/render_frame_host_impl.cc#newcode1524 content/browser/frame_host/render_frame_host_impl.cc:1524: // The created object is strongly bound to ...
5 years, 7 months ago (2015-05-20 15:02:23 UTC) #4
xhwang
comments addressed
5 years, 7 months ago (2015-05-20 18:19:26 UTC) #5
xhwang
https://codereview.chromium.org/1134003009/diff/1/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/1134003009/diff/1/content/browser/frame_host/render_frame_host_impl.cc#newcode1524 content/browser/frame_host/render_frame_host_impl.cc:1524: // The created object is strongly bound to (and ...
5 years, 7 months ago (2015-05-20 18:19:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134003009/20001
5 years, 7 months ago (2015-05-20 18:20:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 20:02:01 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 20:03:38 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d04333fe1022f892eb483709cba1b2adc4ce977
Cr-Commit-Position: refs/heads/master@{#330790}

Powered by Google App Engine
This is Rietveld 408576698