Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: media/mojo/services/mojo_renderer_service.h

Issue 1134003009: media: Use mojo::StrongBinding in mojo media services. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_renderer_impl.cc ('k') | media/mojo/services/mojo_renderer_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_renderer_service.h
diff --git a/media/mojo/services/mojo_renderer_service.h b/media/mojo/services/mojo_renderer_service.h
index 1b8116829b020b92b419240c700302ec2394f2a3..70547f50f552915871c3a7708a80b16c9d480350 100644
--- a/media/mojo/services/mojo_renderer_service.h
+++ b/media/mojo/services/mojo_renderer_service.h
@@ -16,7 +16,7 @@
#include "media/base/media_export.h"
#include "media/base/pipeline_status.h"
#include "media/mojo/interfaces/media_renderer.mojom.h"
-#include "third_party/mojo/src/mojo/public/cpp/bindings/interface_impl.h"
+#include "third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h"
namespace mojo {
class ApplicationConnection;
@@ -32,9 +32,10 @@ class VideoRendererSink;
// A mojo::MediaRenderer implementation that uses media::AudioRenderer to
// decode and render audio to a sink obtained from the ApplicationConnection.
class MEDIA_EXPORT MojoRendererService
- : NON_EXPORTED_BASE(public mojo::InterfaceImpl<mojo::MediaRenderer>) {
+ : NON_EXPORTED_BASE(mojo::MediaRenderer) {
public:
- MojoRendererService();
+ explicit MojoRendererService(
+ mojo::InterfaceRequest<mojo::MediaRenderer> request);
~MojoRendererService() override;
// mojo::MediaRenderer implementation.
@@ -87,6 +88,8 @@ class MEDIA_EXPORT MojoRendererService
// Callback executed once Flush() completes.
void OnFlushCompleted(const mojo::Closure& callback);
+ mojo::StrongBinding<mojo::MediaRenderer> binding_;
+
State state_;
scoped_refptr<AudioRendererSink> audio_renderer_sink_;
« no previous file with comments | « media/mojo/services/mojo_renderer_impl.cc ('k') | media/mojo/services/mojo_renderer_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698