Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1134003009: media: Use mojo::StrongBinding in mojo media services. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/mojo/services/mojo_cdm_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/containers/hash_tables.h" 9 #include "base/containers/hash_tables.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 1503 matching lines...) Expand 10 before | Expand all | Expand 10 after
1514 RenderViewHostDelegateView* view = 1514 RenderViewHostDelegateView* view =
1515 render_view_host_->delegate_->GetDelegateView(); 1515 render_view_host_->delegate_->GetDelegateView();
1516 if (view) 1516 if (view)
1517 view->HidePopupMenu(); 1517 view->HidePopupMenu();
1518 } 1518 }
1519 #endif 1519 #endif
1520 1520
1521 #if defined(ENABLE_MEDIA_MOJO_RENDERER) 1521 #if defined(ENABLE_MEDIA_MOJO_RENDERER)
1522 static void CreateMediaRendererService( 1522 static void CreateMediaRendererService(
1523 mojo::InterfaceRequest<mojo::MediaRenderer> request) { 1523 mojo::InterfaceRequest<mojo::MediaRenderer> request) {
1524 media::MojoRendererService* service = new media::MojoRendererService(); 1524 // The created object is strongly bound to (and owned by) the pipe.
jam 2015/05/20 15:02:23 isn't "strongly bound" and "owned by" redundant? I
xhwang 2015/05/20 18:19:34 Done.
1525 mojo::BindToRequest(service, &request); 1525 new media::MojoRendererService(request.Pass());
1526 } 1526 }
1527 #endif 1527 #endif
1528 1528
1529 void RenderFrameHostImpl::RegisterMojoServices() { 1529 void RenderFrameHostImpl::RegisterMojoServices() {
1530 GeolocationServiceContext* geolocation_service_context = 1530 GeolocationServiceContext* geolocation_service_context =
1531 delegate_ ? delegate_->GetGeolocationServiceContext() : NULL; 1531 delegate_ ? delegate_->GetGeolocationServiceContext() : NULL;
1532 if (geolocation_service_context) { 1532 if (geolocation_service_context) {
1533 // TODO(creis): Bind process ID here so that GeolocationServiceImpl 1533 // TODO(creis): Bind process ID here so that GeolocationServiceImpl
1534 // can perform permissions checks once site isolation is complete. 1534 // can perform permissions checks once site isolation is complete.
1535 // crbug.com/426384 1535 // crbug.com/426384
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
2067 // We may be returning to an existing NavigationEntry that had been granted 2067 // We may be returning to an existing NavigationEntry that had been granted
2068 // file access. If this is a different process, we will need to grant the 2068 // file access. If this is a different process, we will need to grant the
2069 // access again. The files listed in the page state are validated when they 2069 // access again. The files listed in the page state are validated when they
2070 // are received from the renderer to prevent abuse. 2070 // are received from the renderer to prevent abuse.
2071 if (request_params.page_state.IsValid()) { 2071 if (request_params.page_state.IsValid()) {
2072 render_view_host_->GrantFileAccessFromPageState(request_params.page_state); 2072 render_view_host_->GrantFileAccessFromPageState(request_params.page_state);
2073 } 2073 }
2074 } 2074 }
2075 2075
2076 } // namespace content 2076 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | media/mojo/services/mojo_cdm_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698