Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133903005: DevTools: [wip] do not use InspectorInstrumentation for will/didProcessTask events. (Closed)

Created:
5 years, 7 months ago by pfeldman
Modified:
5 years, 5 months ago
Reviewers:
yurys
CC:
blink-reviews, falken, caseq+blink_chromium.org, arv+blink, vivekg_samsung, horo+watch_chromium.org, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, Inactive, devtools-reviews_chromium.org, kinuko+worker_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [wip] do not use InspectorInstrumentation for will/didProcessTask events. BUG=436952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -58 lines) Patch
M Source/bindings/core/v8/WorkerScriptDebugServer.h View 3 chunks +5 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.h View 4 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.cpp View 3 chunks +12 lines, -11 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.h View 5 chunks +7 lines, -1 line 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 4 chunks +19 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerThread.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pfeldman
5 years, 7 months ago (2015-05-14 22:21:18 UTC) #2
sadrul
Hi! Just wanted to check if this is something you are actively working on at ...
5 years, 6 months ago (2015-05-28 16:22:14 UTC) #3
pfeldman
5 years, 6 months ago (2015-05-29 12:37:57 UTC) #4 
On 2015/05/28 16:22:14, sadrul wrote:
> Hi! Just wanted to check if this is something you are actively working on at
the
> moment. Is there anything I can do to help with this CL? You mentioned earlier
> that this is not oilpan-friendly right now. Do you think resolving that should
> be fairly straight-forward, or do you think it would make sense to move
forward
> with https://codereview.chromium.org/1131183003/ until this gets sorted out?

I don't think https://codereview.chromium.org/1131183003/ is doing the right
thing. But it seems that worker thread is useful for significantly simplifying
what this change is doing. If you could pick this one up, that'd be great.

Powered by Google App Engine
This is Rietveld 408576698