Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131183003: WorkerThread: Remove willEnterNestedLoop() and didLeaveNestedLoop().

Created:
5 years, 7 months ago by sadrul
Modified:
5 years, 5 months ago
Reviewers:
kinuko, yurys
CC:
blink-reviews, falken, caseq+blink_chromium.org, arv+blink, vivekg_samsung, horo+watch_chromium.org, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, kinuko+worker_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

WorkerThread: Remove willEnterNestedLoop() and didLeaveNestedLoop(). Directly call into InspectorInstrumentation::willEnterNestedRunLoop() and didLeaveNestedRunLoop() from the callers, and remove willEnterNestedLoop() and didLeaveNestedLoop() from WorkerThread. BUG=436952

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M Source/bindings/core/v8/WorkerScriptDebugServer.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerThread.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sadrul
5 years, 7 months ago (2015-05-11 00:25:37 UTC) #2
kinuko
I'd like defer this to yurys@.
5 years, 7 months ago (2015-05-11 06:01:57 UTC) #3
pfeldman
Lets untangle it a bit further. We'll get back to you.
5 years, 7 months ago (2015-05-11 07:24:12 UTC) #5
sadrul
On 2015/05/11 07:24:12, pfeldman_ooo_may11 wrote: > Lets untangle it a bit further. We'll get back ...
5 years, 7 months ago (2015-05-11 15:48:40 UTC) #6
pfeldman
5 years, 7 months ago (2015-05-11 16:39:42 UTC) #7 
https://codereview.chromium.org/1133903005 is to give you an idea of what I was
talking about. It is not Oilpan-friendly atm and might suffer from accessing
observers that are collected. I'll discuss it with yuyrs.

Powered by Google App Engine
This is Rietveld 408576698