Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133753003: Split gamepad provider from test runner controller (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split gamepad provider from test runner controller This is to remove dependencies from test runner on content BUG=478250 R=mkwst@chromium.org Committed: https://crrev.com/c8337810a51c812ff0872adbc755290b4ade097b Cr-Commit-Position: refs/heads/master@{#329769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -33 lines) Patch
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 3 chunks +28 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.h View 3 chunks +6 lines, -10 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.cc View 4 chunks +10 lines, -18 lines 0 comments Download
M content/shell/renderer/test_runner/test_interfaces.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_delegate.h View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-13 07:26:35 UTC) #1
Mike West
LGTM, as long as the Blink tests keep passing.
5 years, 7 months ago (2015-05-13 09:14:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133753003/1
5 years, 7 months ago (2015-05-14 01:06:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 01:12:07 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 01:12:58 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c8337810a51c812ff0872adbc755290b4ade097b
Cr-Commit-Position: refs/heads/master@{#329769}

Powered by Google App Engine
This is Rietveld 408576698