Use patching for dart:io.

Use patching for dart:io.

This allows the tools such as dartdoc to operate on dart:io
in the same way as it does with other code and allows the
implemenation of parts of dart:io for dart2js if we ever
want to do that.

The current patching is very VM specific. I have only moved
stuff to patch files when they actually need to be. For
Process and Socket everything has to be moved because they
use native fields. For the rest, only the individual native
calls have been put in patch files.

R=sgjesse@google.com,ajohnsen@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=14259

[Mads Ager (google), 2012-10-30 08:58:11]

This is hard to review, sorry. Overall, the changes are that most dart files
from runtime/bin have moved to lib/io. The VM specific parts are in new
_patch.dart files in runtime/bin.

[Søren Gjesse, 2012-10-30 09:28:32]

LGTM!

https://codereview.chromium.org/11337019/diff/1/lib/io/common.dart
File lib/io/common.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/common.dart#newcode92
lib/io/common.dart:92: external static bool _isBuiltinList(List buffer);
So externals cannot be top level functions?

https://codereview.chromium.org/11337019/diff/1/lib/io/directory_impl.dart
File lib/io/directory_impl.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/directory_impl.dart#ne...
lib/io/directory_impl.dart:23: external static _createTemp(String template);
Should we use void where there is no return type?

https://codereview.chromium.org/11337019/diff/1/lib/io/directory_impl.dart#ne...
lib/io/directory_impl.dart:181: _exceptionFromResponse(response, String message)
{
_exceptionFromResponse -> _exceptionOrErrorFromResponse ?

https://codereview.chromium.org/11337019/diff/1/lib/io/file_impl.dart
File lib/io/file_impl.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/file_impl.dart#newcode349
lib/io/file_impl.dart:349: // TODO(ager): The only reason for this class is that
the patching
Answers previous comment. Then add a TODO there as well.

https://codereview.chromium.org/11337019/diff/1/lib/io/io.dart
File lib/io/io.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/io.dart#newcode22
lib/io/io.dart:22: #source('base64.dart');
Shouldn't we change this to the new syntax and use part instead of #source?

https://codereview.chromium.org/11337019/diff/1/lib/io/process.dart
File lib/io/process.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/process.dart#newcode5
lib/io/process.dart:5: class _ProcessUtils {
TODO?

https://codereview.chromium.org/11337019/diff/1/lib/io/stdio.dart
File lib/io/stdio.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/stdio.dart#newcode76
lib/io/stdio.dart:76: class _StdIOUtils {
TODO?

https://codereview.chromium.org/11337019/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/11337019/diff/1/runtime/bin/bin.gypi#newcode1
runtime/bin/bin.gypi:1: 
Accidental edit?

https://codereview.chromium.org/11337019/diff/1/runtime/bin/common_patch.dart
File runtime/bin/common_patch.dart (left):

https://codereview.chromium.org/11337019/diff/1/runtime/bin/common_patch.dart...
runtime/bin/common_patch.dart:5: library hi;
Interesting OLD file :-)

https://codereview.chromium.org/11337019/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/11337019/diff/1/tools/create_sdk.py#newcode226
tools/create_sdk.py:226: for library in ['_internal', 'collection', 'core',
'coreimpl', 'crypto', 'io',
Nice!

[Anders Johnsen, 2012-10-30 10:43:06]

LGTM!!! Thank you for doing this cleanup, this is so nice! :)

https://codereview.chromium.org/11337019/diff/10001/lib/compiler/implementati...
File lib/compiler/implementation/lib/io_patch.dart (right):

https://codereview.chromium.org/11337019/diff/10001/lib/compiler/implementati...
lib/compiler/implementation/lib/io_patch.dart:165: return new
_ServerSocket(bindAddress, port, backlog);
Where is _ServerSocket defined?

https://codereview.chromium.org/11337019/diff/10001/lib/compiler/implementati...
lib/compiler/implementation/lib/io_patch.dart:170: patch factory Socket(String
host, int port) => new _Socket(host, port);
Where is _Socket defined?

https://codereview.chromium.org/11337019/diff/10001/lib/io/common.dart
File lib/io/common.dart (right):

https://codereview.chromium.org/11337019/diff/10001/lib/io/common.dart#newcode90
lib/io/common.dart:90: class _BufferUtils {
Maybe make it abstract then.

https://codereview.chromium.org/11337019/diff/10001/lib/io/eventhandler.dart
File lib/io/eventhandler.dart (right):

https://codereview.chromium.org/11337019/diff/10001/lib/io/eventhandler.dart#...
lib/io/eventhandler.dart:5: class _EventHandler {
This is a quite fundamental part of the IO implementation. I think this class
and the methods could use some docs.

https://codereview.chromium.org/11337019/diff/10001/lib/io/file_impl.dart
File lib/io/file_impl.dart (right):

https://codereview.chromium.org/11337019/diff/10001/lib/io/file_impl.dart#new...
lib/io/file_impl.dart:352: class _FileUtils {
abstract?

https://codereview.chromium.org/11337019/diff/10001/lib/io/http.dart
File lib/io/http.dart (left):

https://codereview.chromium.org/11337019/diff/10001/lib/io/http.dart#oldcode119
lib/io/http.dart:119: int set sessionTimeout(int timeout);
Oops, ty! :)

https://codereview.chromium.org/11337019/diff/10001/lib/io/io.dart
File lib/io/io.dart (right):

https://codereview.chromium.org/11337019/diff/10001/lib/io/io.dart#newcode13
lib/io/io.dart:13: #library('dart:io');
Very very nice! :)

https://codereview.chromium.org/11337019/diff/10001/lib/io/process.dart
File lib/io/process.dart (right):

https://codereview.chromium.org/11337019/diff/10001/lib/io/process.dart#newcode7
lib/io/process.dart:7: class _ProcessUtils {
abstract?

https://codereview.chromium.org/11337019/diff/10001/lib/io/stdio.dart
File lib/io/stdio.dart (right):

https://codereview.chromium.org/11337019/diff/10001/lib/io/stdio.dart#newcode76
lib/io/stdio.dart:76: class _StdIOUtils {
abstract?

https://codereview.chromium.org/11337019/diff/10001/lib/io/websocket_impl.dart
File lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/11337019/diff/10001/lib/io/websocket_impl.dar...
lib/io/websocket_impl.dart:211: break;
This looks wrong to me. If you break here, the 'hack' will not do the correct
thing. Remove hack? Or is there a bug associated with this change?

https://codereview.chromium.org/11337019/diff/10001/runtime/bin/io.dart
File runtime/bin/io.dart (right):

https://codereview.chromium.org/11337019/diff/10001/runtime/bin/io.dart#newcode9
runtime/bin/io.dart:9: #library("dart:io");
Afaik, this is not how we do this. It should just be 'io'. Maybe we should agree
on how all 'dart:...' libraries should be defined?

[Mads Ager (google), 2012-10-30 11:12:40]

Thanks Anders. I agree with the comment about adding documentation to the
eventhandler. Separate patch. :)

https://codereview.chromium.org/11337019/diff/1/lib/io/common.dart
File lib/io/common.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/common.dart#newcode92
lib/io/common.dart:92: external static bool _isBuiltinList(List buffer);
On 2012/10/30 09:28:32, Søren Gjesse wrote:
> So externals cannot be top level functions?

At this point at least they cannot, no. I'll add a comment here as I did the
other place where I had to do this.

https://codereview.chromium.org/11337019/diff/1/lib/io/directory_impl.dart
File lib/io/directory_impl.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/directory_impl.dart#ne...
lib/io/directory_impl.dart:23: external static _createTemp(String template);
On 2012/10/30 09:28:32, Søren Gjesse wrote:
> Should we use void where there is no return type?

There is a return value but it can be either an OSError or a result I believe.
We could use 'dynamic' as the return type but I prefer to just leave out the
type annotation in that case.

https://codereview.chromium.org/11337019/diff/1/lib/io/directory_impl.dart#ne...
lib/io/directory_impl.dart:181: _exceptionFromResponse(response, String message)
{
On 2012/10/30 09:28:32, Søren Gjesse wrote:
> _exceptionFromResponse -> _exceptionOrErrorFromResponse ?

Done.

https://codereview.chromium.org/11337019/diff/1/lib/io/file_impl.dart
File lib/io/file_impl.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/file_impl.dart#newcode349
lib/io/file_impl.dart:349: // TODO(ager): The only reason for this class is that
the patching
On 2012/10/30 09:28:32, Søren Gjesse wrote:
> Answers previous comment. Then add a TODO there as well.

Done.

https://codereview.chromium.org/11337019/diff/1/lib/io/io.dart
File lib/io/io.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/io.dart#newcode22
lib/io/io.dart:22: #source('base64.dart');
On 2012/10/30 09:28:32, Søren Gjesse wrote:
> Shouldn't we change this to the new syntax and use part instead of #source?

Yes, but I'd like to postpone that to a separate change. This is getting massive
and we need to use part of as well.

https://codereview.chromium.org/11337019/diff/1/lib/io/process.dart
File lib/io/process.dart (right):

https://codereview.chromium.org/11337019/diff/1/lib/io/process.dart#newcode5
lib/io/process.dart:5: class _ProcessUtils {
On 2012/10/30 09:28:32, Søren Gjesse wrote:
> TODO?

Done.

https://codereview.chromium.org/11337019/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/11337019/diff/1/runtime/bin/bin.gypi#newcode1
runtime/bin/bin.gypi:1: 
On 2012/10/30 09:28:32, Søren Gjesse wrote:
> Accidental edit?

Yes, thanks!

https://codereview.chromium.org/11337019/diff/1/runtime/bin/common_patch.dart
File runtime/bin/common_patch.dart (left):

https://codereview.chromium.org/11337019/diff/1/runtime/bin/common_patch.dart...
runtime/bin/common_patch.dart:5: library hi;
On 2012/10/30 09:28:32, Søren Gjesse wrote:
> Interesting OLD file :-)

I need to play with the similarity setting when using git cl upload. :-)

https://codereview.chromium.org/11337019/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/11337019/diff/1/tools/create_sdk.py#newcode226
tools/create_sdk.py:226: for library in ['_internal', 'collection', 'core',
'coreimpl', 'crypto', 'io',
On 2012/10/30 09:28:32, Søren Gjesse wrote:
> Nice!

Yes! :)

https://codereview.chromium.org/11337019/diff/10001/lib/io/websocket_impl.dart
File lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/11337019/diff/10001/lib/io/websocket_impl.dar...
lib/io/websocket_impl.dart:211: break;
On 2012/10/30 10:43:06, ajohnsen wrote:
> This looks wrong to me. If you break here, the 'hack' will not do the correct
> thing. Remove hack? Or is there a bug associated with this change?

This is the end of a switch case, so the only thing we are breaking out from is
the switch. :)

https://codereview.chromium.org/11337019/diff/10001/runtime/bin/io.dart
File runtime/bin/io.dart (right):

https://codereview.chromium.org/11337019/diff/10001/runtime/bin/io.dart#newcode9
runtime/bin/io.dart:9: #library("dart:io");
On 2012/10/30 10:43:06, ajohnsen wrote:
> Afaik, this is not how we do this. It should just be 'io'. Maybe we should
agree
> on how all 'dart:...' libraries should be defined?

I'm making this consistent with what is in the lib/foo/foo.dart files. This
makes it look right in dartdoc among other things.