Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: lib/io/stdio.dart

Issue 11337019: Use patching for dart:io. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/io/stdio.dart
diff --git a/runtime/bin/stdio.dart b/lib/io/stdio.dart
similarity index 84%
rename from runtime/bin/stdio.dart
rename to lib/io/stdio.dart
index 727c3754e780891713138b7a1a8188d74bd49d16..e080526104de819bd1eac4e6238210e8e61e2df2 100644
--- a/runtime/bin/stdio.dart
+++ b/lib/io/stdio.dart
@@ -15,12 +15,12 @@ OutputStream _stderr;
InputStream _getStdioInputStream() {
- switch (_getStdioHandleType(0)) {
+ switch (_StdIOUtils._getStdioHandleType(0)) {
case _STDIO_HANDLE_TYPE_TERMINAL:
case _STDIO_HANDLE_TYPE_PIPE:
case _STDIO_HANDLE_TYPE_SOCKET:
Socket s = new _Socket._internalReadOnly();
- _getStdioHandle(s, 0);
+ _StdIOUtils._getStdioHandle(s, 0);
s._closed = false;
return s.inputStream;
case _STDIO_HANDLE_TYPE_FILE:
@@ -33,12 +33,12 @@ InputStream _getStdioInputStream() {
OutputStream _getStdioOutputStream(int fd) {
assert(fd == 1 || fd == 2);
- switch (_getStdioHandleType(fd)) {
+ switch (_StdIOUtils._getStdioHandleType(fd)) {
case _STDIO_HANDLE_TYPE_TERMINAL:
case _STDIO_HANDLE_TYPE_PIPE:
case _STDIO_HANDLE_TYPE_SOCKET:
Socket s = new _Socket._internalWriteOnly();
- _getStdioHandle(s, fd);
+ _StdIOUtils._getStdioHandle(s, fd);
s._closed = false;
return s.outputStream;
case _STDIO_HANDLE_TYPE_FILE:
@@ -72,5 +72,8 @@ OutputStream get stderr {
return _stderr;
}
-_getStdioHandle(Socket socket, int num) native "Socket_GetStdioHandle";
-_getStdioHandleType(int num) native "File_GetStdioHandleType";
+
+class _StdIOUtils {
Anders Johnsen 2012/10/30 10:43:06 abstract?
+ external static _getStdioHandle(Socket socket, int num);
+ external static _getStdioHandleType(int num);
+}

Powered by Google App Engine
This is Rietveld 408576698