DescriptionOmnibox - Log Addition Crash Data for Rare HQP Crash
In the days of yore, there was an HQP crash:
https://code.google.com/p/chromium/issues/detail?id=359270
I put a band-aid on the crash:
https://codereview.chromium.org/222783006
Later, I fixed the root cause:
https://codereview.chromium.org/255423002
Or at least I thought I did and close that days-of-yore bug.
Apparently this didn't entirely fix the problem. (See the linked bug
below.)
This change adds some information to the minidumps to allow me to
investigate what kinds of inputs are causing trouble.
BUG=464926
Committed: https://crrev.com/55b415e1407aa2fd0b7f095c9972c28fb053cb96
Cr-Commit-Position: refs/heads/master@{#329703}
Patch Set 1 #Patch Set 2 : better key name #
Total comments: 4
Patch Set 3 : dcheck -> check #Patch Set 4 : more descriptive CHECK message - DO NOT SUBMIT #Patch Set 5 : register crash key #Patch Set 6 : reuse constant #
Total comments: 2
Patch Set 7 : use fixed_keys array #
Messages
Total messages: 25 (9 generated)
|