Omnibox: Fix HQP Crash on Bad FormatURL and can_inline Interaction

Omnibox: Fix HQP Crash on Bad FormatURL and can_inline Interaction

The comment in this change explains it all.

I cannot test this fix because I don't know what particular data causes
it, but I think my theory is good and I'm confident based on the
stack traces that it fixes the linked crashes.

BUG=359270
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264143

[Mark P, 2014-04-10 23:49:53]

Please take a look at the 25 characters of new code and the 11 lines of new
comments.  :-)

thanks,
mark

[Peter Kasting, 2014-04-14 22:13:21]

RSLGTM

https://codereview.chromium.org/222783006/diff/20001/chrome/browser/autocompl...
File chrome/browser/autocomplete/history_quick_provider.cc (right):

https://codereview.chromium.org/222783006/diff/20001/chrome/browser/autocompl...
chrome/browser/autocomplete/history_quick_provider.cc:289: // TODO(mpearson):
try removing the second clause after fixing 252630.
Nit: removing the second clause -> replacing the second clause with a DCHECK

(And then remove the DCHECK inside the conditional.)

[Mark P, 2014-04-14 23:34:19]

RSLGTM?
RS = ?

--mark

https://codereview.chromium.org/222783006/diff/20001/chrome/browser/autocompl...
File chrome/browser/autocomplete/history_quick_provider.cc (right):

https://codereview.chromium.org/222783006/diff/20001/chrome/browser/autocompl...
chrome/browser/autocomplete/history_quick_provider.cc:289: // TODO(mpearson):
try removing the second clause after fixing 252630.
On 2014/04/14 22:13:21, Peter Kasting wrote:
> Nit: removing the second clause -> replacing the second clause with a DCHECK

Done.

> (And then remove the DCHECK inside the conditional.)

Done.

[Peter Kasting, 2014-04-14 23:45:30]

On 2014/04/14 23:34:19, Mark P wrote:
> RSLGTM?
> RS = ?

"Rubber stamp".  It means I read your comment, but I didn't think deeply on
whether your explanation was plausible.

[Mark P, 2014-04-14 23:47:51]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-04-14 23:49:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/222783006/30001

[commit-bot: I haz the power, 2014-04-15 01:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 01:08:56]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[Mark P, 2014-04-15 02:47:12]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-04-15 02:48:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/222783006/30001

[commit-bot: I haz the power, 2014-04-15 03:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 03:04:28]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Mark P, 2014-04-15 16:11:07]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-04-15 16:11:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/222783006/30001

[commit-bot: I haz the power, 2014-04-15 17:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 17:06:05]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[Mark P, 2014-04-15 21:34:34]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-04-15 21:36:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/222783006/30001

[commit-bot: I haz the power, 2014-04-16 01:28:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/222783006/30001

[commit-bot: I haz the power, 2014-04-16 07:05:11]

Change committed as 264143