Omnibox - Log Addition Crash Data for Rare HQP Crash

chrome/common/crash_keys.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/crash_keys.h"
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/strings/string_split.h"
@@ skipping 110 matching lines @@
 const char kZombieTrace[] = "zombie_dealloc_bt";
 
 }  // namespace mac
 #endif
 
 #if defined(KASKO)
 const char kKaskoGuid[] = "kasko-guid";
 const char kKaskoEquivalentGuid[] = "kasko-equivalent-guid";
 #endif
 
+const char kBug464926CrashKey[] = "bug-464926-info";
+
 size_t RegisterChromeCrashKeys() {
   // The following keys may be chunked by the underlying crash logging system,
   // but ultimately constitute a single key-value pair.
   base::debug::CrashKey fixed_keys[] = {
 #if defined(OS_MACOSX)
     { kMetricsClientId, kSmallSize },
 #else
     { kClientId, kSmallSize },
 #endif
     { kChannel, kSmallSize },
@@ skipping 95 matching lines @@
     for (size_t i = 0; i < kPrinterInfoCount; ++i) {
       // Key names are 1-indexed.
       int n = base::snprintf(
           formatted_keys[i], formatted_key_len, kPrinterInfo, i + 1);
       DCHECK_GT(n, 0);
       base::debug::CrashKey crash_key = { formatted_keys[i], kSmallSize };
       keys.push_back(crash_key);
     }
   }
 
+  // Register a key to help investigate bug 464926.

[Robert Sesek, 2015/05/13 15:22:34]

This should just go in the fixed_keys array.

[Mark P, 2015/05/13 17:50:14]

Okay.  Done.

In the future, you may want to revise the fixed_keys name or comment.  I
intentionally didn't put this key in there because the name fixed_keys made me
think these keys are the ones always uploaded with chrome (on platforms), not
keys that can appear or disappear based on the crash context (i.e., keys that
are not fixed / not consistent / not permanent).

+  {
+    base::debug::CrashKey crash_key = { kBug464926CrashKey, kSmallSize };
+    keys.push_back(crash_key);
+  }
+
   return base::debug::InitCrashKeys(&keys.at(0), keys.size(),
                                     kSingleChunkLength);
 }
 
 void SetMetricsClientIdFromGUID(const std::string& metrics_client_guid) {
   std::string stripped_guid(metrics_client_guid);
   // Remove all instance of '-' char from the GUID. So BCD-WXY becomes BCDWXY.
   ReplaceSubstringsAfterOffset(&stripped_guid, 0, "-", "");
   if (stripped_guid.empty())
     return;
@@ skipping 179 matching lines @@
 }
 
 ScopedPrinterInfo::~ScopedPrinterInfo() {
   for (size_t i = 0; i < kPrinterInfoCount; ++i) {
     std::string key = base::StringPrintf(kPrinterInfo, i + 1);
     base::debug::ClearCrashKey(key);
   }
 }
 
 }  // namespace crash_keys