Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issue 1132913004: [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost (Closed)

Created:
5 years, 7 months ago by vkuzkokov
Modified:
5 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix potential crash in RenderFrameDevToolsAgentHost BUG=483693 Committed: https://crrev.com/1771428fefada2d24fab5970b915b941a5014cc1 Cr-Commit-Position: refs/heads/master@{#330286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vkuzkokov
First crash in crbug.com/483693 is more time-consistent with https://codereview.chromium.org/1094153002 rather than the CL reported in ...
5 years, 7 months ago (2015-05-15 19:17:08 UTC) #2
pfeldman
lgtm
5 years, 7 months ago (2015-05-15 23:06:38 UTC) #4
dgozman
Good catch! lgtm
5 years, 7 months ago (2015-05-16 01:35:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132913004/1
5 years, 7 months ago (2015-05-16 11:23:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-16 11:26:11 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1771428fefada2d24fab5970b915b941a5014cc1 Cr-Commit-Position: refs/heads/master@{#330286}
5 years, 7 months ago (2015-05-18 11:31:50 UTC) #9
vkuzkokov
5 years, 7 months ago (2015-05-18 11:39:52 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1140603004/ by vkuzkokov@chromium.org.

The reason for reverting is: See crbug.com/489135.

Powered by Google App Engine
This is Rietveld 408576698