Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 1132913004: [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index 6f40d6fae6aa8b86237eeb9a44f1ed6f5efb87f9..665885a2f96cd33c78765f585e5dce334148d1d0 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -417,6 +417,7 @@ void RenderFrameDevToolsAgentHost::SetRenderFrameHost(RenderFrameHost* rfh) {
void RenderFrameDevToolsAgentHost::ClearRenderFrameHost() {
DCHECK(render_frame_host_);
render_frame_host_ = nullptr;
+ WebContentsObserver::Observe(nullptr);
dom_handler_->SetRenderFrameHost(nullptr);
if (emulation_handler_)
emulation_handler_->SetRenderFrameHost(nullptr);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698