Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: components/scheduler/child/test_time_source.h

Issue 1132753008: Replaced TestNowSource with SimpleTestTickClock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments: scoped leaking clocks, refactored num_now_calls_ functionality Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/child/test_time_source.h
diff --git a/components/scheduler/child/test_time_source.h b/components/scheduler/child/test_time_source.h
index 6219a4dbd8afa92b0d0d7f5c4bdbab197f661243..c9b7e476db0c1565f2d44f56795bfadf06171b21 100644
--- a/components/scheduler/child/test_time_source.h
+++ b/components/scheduler/child/test_time_source.h
@@ -6,23 +6,20 @@
#define COMPONENTS_SCHEDULER_CHILD_TEST_TIME_SOURCE_H_
#include "base/memory/ref_counted.h"
+#include "base/test/simple_test_tick_clock.h"
#include "components/scheduler/child/time_source.h"
-namespace cc {
-class TestNowSource;
-}
-
namespace scheduler {
class TestTimeSource : public TimeSource {
public:
- explicit TestTimeSource(scoped_refptr<cc::TestNowSource> time_source);
+ explicit TestTimeSource(base::SimpleTestTickClock* time_source);
~TestTimeSource() override;
base::TimeTicks Now() const override;
private:
- scoped_refptr<cc::TestNowSource> time_source_;
+ base::SimpleTestTickClock* time_source_;
Sami 2015/06/04 14:47:07 Can you split this change out since you had anothe
Ankur Verma 2015/06/04 15:25:08 I could not understand completely (this being my f
Ankur Verma 2015/06/05 14:39:16 On rebasing for patch set 8, i realised that https
DISALLOW_COPY_AND_ASSIGN(TestTimeSource);
};

Powered by Google App Engine
This is Rietveld 408576698