Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Side by Side Diff: components/scheduler/child/test_time_source.h

Issue 1132753008: Replaced TestNowSource with SimpleTestTickClock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments: scoped leaking clocks, refactored num_now_calls_ functionality Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SCHEDULER_CHILD_TEST_TIME_SOURCE_H_ 5 #ifndef COMPONENTS_SCHEDULER_CHILD_TEST_TIME_SOURCE_H_
6 #define COMPONENTS_SCHEDULER_CHILD_TEST_TIME_SOURCE_H_ 6 #define COMPONENTS_SCHEDULER_CHILD_TEST_TIME_SOURCE_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/test/simple_test_tick_clock.h"
9 #include "components/scheduler/child/time_source.h" 10 #include "components/scheduler/child/time_source.h"
10 11
11 namespace cc {
12 class TestNowSource;
13 }
14
15 namespace scheduler { 12 namespace scheduler {
16 13
17 class TestTimeSource : public TimeSource { 14 class TestTimeSource : public TimeSource {
18 public: 15 public:
19 explicit TestTimeSource(scoped_refptr<cc::TestNowSource> time_source); 16 explicit TestTimeSource(base::SimpleTestTickClock* time_source);
20 ~TestTimeSource() override; 17 ~TestTimeSource() override;
21 18
22 base::TimeTicks Now() const override; 19 base::TimeTicks Now() const override;
23 20
24 private: 21 private:
25 scoped_refptr<cc::TestNowSource> time_source_; 22 base::SimpleTestTickClock* time_source_;
Sami 2015/06/04 14:47:07 Can you split this change out since you had anothe
Ankur Verma 2015/06/04 15:25:08 I could not understand completely (this being my f
Ankur Verma 2015/06/05 14:39:16 On rebasing for patch set 8, i realised that https
26 23
27 DISALLOW_COPY_AND_ASSIGN(TestTimeSource); 24 DISALLOW_COPY_AND_ASSIGN(TestTimeSource);
28 }; 25 };
29 26
30 } // namespace scheduler 27 } // namespace scheduler
31 28
32 #endif // COMPONENTS_SCHEDULER_CHILD_TEST_TIME_SOURCE_H_ 29 #endif // COMPONENTS_SCHEDULER_CHILD_TEST_TIME_SOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698