Scheduler/child/TimeSource could be replaced with base/time/DefaultTickClock.

Scheduler/child/TimeSource could be replaced with base/time/DefaultTickClock.

They both are totally same and TimeSource is removed.

BUG=494892
R=skyostil@chromium.org, mithro@mithis.com

Committed: https://crrev.com/76f36a8362a3e817cc3ec721d591f2f8878dc0c7
Cr-Commit-Position: refs/heads/master@{#333035}

[Jimmy Jo, 2015-06-04 12:13:08]

Patchset #1 (id:1) has been deleted

[Jimmy Jo, 2015-06-04 12:15:43]

jincheol.jo@navercorp.com changed reviewers:
+ mithro@mithis.com, skyostil@chromium.org

[Jimmy Jo, 2015-06-04 13:09:44]

PTAL!!

[Sami, 2015-06-04 13:51:47]

Thanks for the clean-up!

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
File components/scheduler/child/scheduler_helper.h (right):

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/scheduler_helper.h:8: #include
"base/time/default_tick_clock.h"
Could you forward declare this instead?

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/scheduler_helper.h:96: void
SetTimeSourceForTesting(scoped_ptr<base::DefaultTickClock> time_source);
I think this should be base::TickClock since we don't really care that
DefaultTickClock is involved.

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/scheduler_helper.h:113:
scoped_ptr<base::DefaultTickClock> time_source_;
base::TickClock here too.

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
File components/scheduler/child/task_queue_manager.h (right):

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/task_queue_manager.h:160: void
SetTimeSourceForTesting(scoped_ptr<base::DefaultTickClock> time_source);
Ditto.

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/task_queue_manager.h:250:
scoped_ptr<base::DefaultTickClock> time_source_;
Ditto.

[Jimmy Jo, 2015-06-05 00:45:10]

Right!! I missed important things to hide child class.

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
File components/scheduler/child/scheduler_helper.h (right):

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/scheduler_helper.h:8: #include
"base/time/default_tick_clock.h"
On 2015/06/04 13:51:47, Sami wrote:
> Could you forward declare this instead?

Done.

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/scheduler_helper.h:96: void
SetTimeSourceForTesting(scoped_ptr<base::DefaultTickClock> time_source);
On 2015/06/04 13:51:47, Sami wrote:
> I think this should be base::TickClock since we don't really care that
> DefaultTickClock is involved.

Done.

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/scheduler_helper.h:113:
scoped_ptr<base::DefaultTickClock> time_source_;
On 2015/06/04 13:51:47, Sami wrote:
> base::TickClock here too.

Done.

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
File components/scheduler/child/task_queue_manager.h (right):

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/task_queue_manager.h:160: void
SetTimeSourceForTesting(scoped_ptr<base::DefaultTickClock> time_source);
On 2015/06/04 13:51:47, Sami wrote:
> Ditto.

Done.

https://codereview.chromium.org/1163143002/diff/20001/components/scheduler/ch...
components/scheduler/child/task_queue_manager.h:250:
scoped_ptr<base::DefaultTickClock> time_source_;
On 2015/06/04 13:51:47, Sami wrote:
> Ditto.

Done.

[mithro-old, 2015-06-05 03:03:42]

LGTM - I started the CL running on the trybots to make sure it compiles and
tests pass.

You'll need a LGTM from an OWNER in components/ before it can be sent to the
commit queue though.

[Sami, 2015-06-05 11:37:16]

Thanks, components/scheduler lgtm.

[Jimmy Jo, 2015-06-05 11:57:59]

On 2015/06/05 11:37:16, Sami wrote:
> Thanks, components/scheduler lgtm.

Thank you for review. Sami, Mithro.

[Jimmy Jo, 2015-06-05 11:58:09]

The CQ bit was checked by jincheol.jo@navercorp.com

[commit-bot: I haz the power, 2015-06-05 11:58:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163143002/60001

[commit-bot: I haz the power, 2015-06-05 12:01:35]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-06-05 12:02:31]

Patchset 3 (id:??) landed as
https://crrev.com/76f36a8362a3e817cc3ec721d591f2f8878dc0c7
Cr-Commit-Position: refs/heads/master@{#333035}