Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1132323003: Revert of Preliminary attempt to remove batch tracker (Closed)

Created:
5 years, 7 months ago by joshualitt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanup5
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Preliminary attempt to remove batch tracker (patchset #3 id:40001 of https://codereview.chromium.org/1139723004/) Reason for revert: breaking bots Original issue's description: > Preliminary attempt to remove batch tracker > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/cbfe91d82500f4ae8c3ff7bd74b3021a4b89fd84 TBR=robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/d3a560fa80bfb3e2d2e989f951bb3b1c52316654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+815 lines, -513 lines) Patch
M gm/beziereffects.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 10 chunks +49 lines, -32 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 3 chunks +18 lines, -5 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 7 chunks +24 lines, -5 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 5 chunks +25 lines, -15 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 6 chunks +20 lines, -10 lines 0 comments Download
M src/gpu/GrBatchTarget.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 6 chunks +23 lines, -10 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 13 chunks +62 lines, -63 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 2 chunks +29 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 29 chunks +142 lines, -79 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 1 chunk +32 lines, -0 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +6 lines, -13 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 3 chunks +17 lines, -13 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrTestBatch.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 10 chunks +14 lines, -19 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 22 chunks +86 lines, -48 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 3 chunks +6 lines, -9 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 8 chunks +31 lines, -21 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 24 chunks +71 lines, -65 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 12 chunks +17 lines, -27 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 24 chunks +81 lines, -52 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.h View 1 chunk +10 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.cpp View 1 chunk +21 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Preliminary attempt to remove batch tracker
5 years, 7 months ago (2015-05-19 14:14:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132323003/1
5 years, 7 months ago (2015-05-19 14:14:59 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 14:15:39 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d3a560fa80bfb3e2d2e989f951bb3b1c52316654

Powered by Google App Engine
This is Rietveld 408576698