Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1132103009: Example of refactoring using rope library. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tfarina, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Example of refactoring using rope library. See tools/telemetry/refactor.py In that script, I make a simple rename of "StoriesGroupedByStateClass" -> StoriesByStateClass in user_story_runner.py file. rope library correctly updates the usage of that method in user_story_runner_unittest.py as well. (https://github.com/python-rope/rope)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35937 lines, -4 lines) Patch
A tools/telemetry/.ropeproject/config.py View 1 chunk +97 lines, -0 lines 0 comments Download
A tools/telemetry/refactor.py View 1 chunk +27 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/story_runner.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/story_runner_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
A tools/telemetry/third_party/rope/.gitignore View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/.travis.yml View 1 chunk +18 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/CONTRIBUTORS View 1 chunk +14 lines, -0 lines 0 comments Download
A + tools/telemetry/third_party/rope/COPYING View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/third_party/rope/MANIFEST.in View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/README.rst View 1 chunk +64 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/docs/contributing.rst View 1 chunk +107 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/docs/dev/issues.rst View 1 chunk +156 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/docs/dev/todo.rst View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/docs/done.rst View 1 chunk +1114 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/docs/library.rst View 1 chunk +890 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/docs/overview.rst View 1 chunk +1243 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/docs/rope.rst View 1 chunk +55 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/__init__.py View 1 chunk +17 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/__init__.py View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/arguments.py View 1 chunk +111 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/ast.py View 1 chunk +76 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/astutils.py View 1 chunk +61 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/builtins.py View 1 chunk +804 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/change.py View 1 chunk +450 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/codeanalyze.py View 1 chunk +362 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/default_config.py View 1 chunk +95 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/evaluate.py View 1 chunk +327 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/exceptions.py View 1 chunk +61 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/fscommands.py View 1 chunk +283 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/history.py View 1 chunk +235 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/libutils.py View 1 chunk +122 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/oi/__init__.py View 1 chunk +38 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/oi/doa.py View 1 chunk +166 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/oi/memorydb.py View 1 chunk +127 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/oi/objectdb.py View 1 chunk +179 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/oi/objectinfo.py View 1 chunk +232 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/oi/runmod.py View 1 chunk +227 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/oi/soa.py View 1 chunk +139 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/oi/soi.py View 1 chunk +197 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/oi/transform.py View 1 chunk +285 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/prefs.py View 1 chunk +41 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/project.py View 1 chunk +498 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/pycore.py View 1 chunk +346 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/pynames.py View 1 chunk +201 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/pynamesdef.py View 1 chunk +55 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/pyobjects.py View 1 chunk +311 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/pyobjectsdef.py View 1 chunk +549 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/pyscopes.py View 1 chunk +314 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/resourceobserver.py View 1 chunk +272 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/resources.py View 1 chunk +243 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/simplify.py View 1 chunk +55 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/stdmods.py View 1 chunk +46 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/taskhandle.py View 1 chunk +131 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/utils.py View 1 chunk +83 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/base/worder.py View 1 chunk +525 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/contrib/__init__.py View 1 chunk +7 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/contrib/autoimport.py View 1 chunk +222 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/contrib/changestack.py View 1 chunk +52 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/contrib/codeassist.py View 1 chunk +695 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/contrib/finderrors.py View 1 chunk +91 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/contrib/findit.py View 1 chunk +114 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/contrib/fixmodnames.py View 1 chunk +69 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/contrib/fixsyntax.py View 1 chunk +181 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/contrib/generate.py View 1 chunk +362 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/__init__.py View 1 chunk +55 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/change_signature.py View 1 chunk +352 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/encapsulate_field.py View 1 chunk +209 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/extract.py View 1 chunk +804 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/functionutils.py View 1 chunk +222 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/importutils/__init__.py View 1 chunk +311 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/importutils/actions.py View 1 chunk +361 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/importutils/importinfo.py View 1 chunk +201 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/importutils/module_imports.py View 1 chunk +493 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/inline.py View 1 chunk +625 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/introduce_factory.py View 1 chunk +135 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/introduce_parameter.py View 1 chunk +96 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/localtofield.py View 1 chunk +49 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/method_object.py View 1 chunk +90 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/move.py View 1 chunk +718 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/multiproject.py View 1 chunk +78 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/occurrences.py View 1 chunk +384 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/patchedast.py View 1 chunk +753 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/rename.py View 1 chunk +220 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/restructure.py View 1 chunk +307 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/similarfinder.py View 1 chunk +370 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/sourceutils.py View 1 chunk +91 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/suites.py View 1 chunk +143 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/topackage.py View 1 chunk +32 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/usefunction.py View 1 chunk +174 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/rope/refactor/wildcards.py View 1 chunk +178 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/__init__.py View 1 chunk +43 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/advanced_oi_test.py View 1 chunk +754 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/builtinstest.py View 1 chunk +511 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/codeanalyzetest.py View 1 chunk +625 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/contrib/__init__.py View 1 chunk +32 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/contrib/autoimporttest.py View 1 chunk +167 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/contrib/changestacktest.py View 1 chunk +35 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/contrib/codeassisttest.py View 1 chunk +1131 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/contrib/finderrorstest.py View 1 chunk +52 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/contrib/findittest.py View 1 chunk +123 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/contrib/fixmodnamestest.py View 1 chunk +56 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/contrib/generatetest.py View 1 chunk +279 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/historytest.py View 1 chunk +416 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/objectdbtest.py View 1 chunk +160 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/objectinfertest.py View 1 chunk +331 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/projecttest.py View 1 chunk +1038 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/pycoretest.py View 1 chunk +1107 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/pyscopestest.py View 1 chunk +258 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/__init__.py View 1 chunk +938 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/change_signature_test.py View 1 chunk +446 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/extracttest.py View 1 chunk +958 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/importutilstest.py View 1 chunk +1054 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/inlinetest.py View 1 chunk +658 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/movetest.py View 1 chunk +687 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/multiprojecttest.py View 1 chunk +70 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/patchedasttest.py View 1 chunk +867 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/renametest.py View 1 chunk +692 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/restructuretest.py View 1 chunk +187 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/similarfindertest.py View 1 chunk +282 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/suitestest.py View 1 chunk +139 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/refactor/usefunctiontest.py View 1 chunk +125 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/runmodtest.py View 1 chunk +163 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/simplifytest.py View 1 chunk +68 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/ropetest/testutils.py View 1 chunk +98 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/rope/setup.py View 1 chunk +62 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698