Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: tools/telemetry/telemetry/internal/story_runner.py

Issue 1132103009: Example of refactoring using rope library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/refactor.py ('k') | tools/telemetry/telemetry/internal/story_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/internal/story_runner.py
diff --git a/tools/telemetry/telemetry/internal/story_runner.py b/tools/telemetry/telemetry/internal/story_runner.py
index 7ddeaff62caa057da0a5dd36ce0486ed67f4a68d..ca6e24f5ec6e436e7d7f7817a59f637a2f81eca8 100644
--- a/tools/telemetry/telemetry/internal/story_runner.py
+++ b/tools/telemetry/telemetry/internal/story_runner.py
@@ -130,7 +130,7 @@ class UserStoryGroup(object):
self._user_stories.append(user_story)
-def StoriesGroupedByStateClass(user_story_set, allow_multiple_groups):
+def StoriesByStateClass(user_story_set, allow_multiple_groups):
""" Returns a list of user story groups which each contains user stories with
the same shared_state_class.
@@ -197,7 +197,7 @@ def Run(test, user_story_set, expectations, finder_options, results,
if effective_max_failures is None:
effective_max_failures = max_failures
- user_story_groups = StoriesGroupedByStateClass(
+ user_story_groups = StoriesByStateClass(
user_stories,
user_story_set.allow_mixed_story_states)
« no previous file with comments | « tools/telemetry/refactor.py ('k') | tools/telemetry/telemetry/internal/story_runner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698