Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: tools/telemetry/telemetry/internal/story_runner_unittest.py

Issue 1132103009: Example of refactoring using rope library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/internal/story_runner.py ('k') | tools/telemetry/third_party/rope/.gitignore » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/internal/story_runner_unittest.py
diff --git a/tools/telemetry/telemetry/internal/story_runner_unittest.py b/tools/telemetry/telemetry/internal/story_runner_unittest.py
index 65959c76279993ba25746024c109d046028d2074..ac26acf57fda61ec29c7436331149056224df904 100644
--- a/tools/telemetry/telemetry/internal/story_runner_unittest.py
+++ b/tools/telemetry/telemetry/internal/story_runner_unittest.py
@@ -175,18 +175,18 @@ class StoryRunnerTest(unittest.TestCase):
# UserStorySet's are only allowed to have one SharedState.
us = SetupUserStorySet(False, foo_states)
story_groups = (
- story_runner.StoriesGroupedByStateClass(
+ story_runner.StoriesByStateClass(
us, False))
self.assertEqual(len(story_groups), 1)
us = SetupUserStorySet(False, mixed_states)
self.assertRaises(
ValueError,
- story_runner.StoriesGroupedByStateClass,
+ story_runner.StoriesByStateClass,
us, False)
# BaseUserStorySets are allowed to have multiple SharedStates.
bus = SetupUserStorySet(True, mixed_states)
story_groups = (
- story_runner.StoriesGroupedByStateClass(
+ story_runner.StoriesByStateClass(
bus, True))
self.assertEqual(len(story_groups), 3)
self.assertEqual(story_groups[0].shared_state_class,
« no previous file with comments | « tools/telemetry/telemetry/internal/story_runner.py ('k') | tools/telemetry/third_party/rope/.gitignore » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698