Rationalize Dart mojo and sky package structure

Rationalize Dart mojo and sky package structure.

NOTE: This CL appears far larger than it actually is for two reasons:

1) Many files were moved around to use the Dart package directory structure.
2) Many .dart files had to have import paths updated.

- Organize mojo/public/dart so that it uses standard Dart package layout
- Organize mojo/dart/apptest so that it uses a standard Dart package layout
- Organize sky/sdk so that it uses a standard Dart package layout
- Create a mojo/testing package (used by unittests)
- Introduce the 'dart_pkg' gn rule which populates gen/Config/dart-pkg
- All internally vended Dart packages must have a corresponding dart_pkg rule
- It is now possible to use dependency_overrides: in pubspec.yaml to mix internal and external package dependencies (enables analyzer, editor, webstorm usage for internal developers).
- Package root for dart content handler ends with "packages/"
- Imports of mojo package uris no longer need the "public/dart"
- mojo/public/tools/dart_package.py is a clone of mojo/public/tools/gn/zip.py
- Sky tests no longer run 'deploy_sdk' script.

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/1a396394dd951450f0ff5c2da81dced0ca18e8c8

[Cutch, 2015-05-14 23:54:03]

johnmccutchan@google.com changed reviewers:
+ blundell@google.com, eseidel@google.com

[Cutch, 2015-05-15 22:21:14]

https://codereview.chromium.org/1132063007/diff/20001/mojo/public/tools/dart_...
File mojo/public/tools/dart_package.py (right):

https://codereview.chromium.org/1132063007/diff/20001/mojo/public/tools/dart_...
mojo/public/tools/dart_package.py:7: """Archives a set of dart packages"""
This is a slightly modified clone of mojo/public/tools/gn/zip.py

[eseidel, 2015-05-15 23:12:43]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-05-15 23:12:44]

This is really big. I wonder if we can't do this in smaller pieces?  Like just
the mojo re-org to start...

[Cutch, 2015-05-15 23:49:46]

On 2015/05/15 23:12:44, eseidel wrote:
> This is really big. I wonder if we can't do this in smaller pieces?  Like just
> the mojo re-org to start...

We could, but, most of this CL is just fall out (file moves and import rewrites)
from the restructuring. The interesting bits can be found here:

mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl
mojo/public/tools/bindings/generators/mojom_dart_generator.py
mojo/public/tools/dart_analyze.py
mojo/public/tools/dart_list_mojoms.py
mojo/public/tools/dart_list_packages_contents.py
mojo/public/tools/dart_package.py
mojo/public/tools/dart_package_name.py
mojo/public/dart/rules.gni
mojo/public/tools/dart_pkg.py
sky/tools/webkitpy/layout_tests/port/base.py
tools/dart/patch_sdk.diff

That being said, if we must, I'll split this into more digestible pieces on
Monday.

[viettrungluu, 2015-05-15 23:56:12]

On 2015/05/15 23:49:46, Cutch wrote:
> On 2015/05/15 23:12:44, eseidel wrote:
> > This is really big. I wonder if we can't do this in smaller pieces?  Like
just
> > the mojo re-org to start...
> 
> We could, but, most of this CL is just fall out (file moves and import
rewrites)
> from the restructuring. The interesting bits can be found here:
> 
> mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl
> mojo/public/tools/bindings/generators/mojom_dart_generator.py
> mojo/public/tools/dart_analyze.py
> mojo/public/tools/dart_list_mojoms.py
> mojo/public/tools/dart_list_packages_contents.py
> mojo/public/tools/dart_package.py
> mojo/public/tools/dart_package_name.py
> mojo/public/dart/rules.gni
> mojo/public/tools/dart_pkg.py
> sky/tools/webkitpy/layout_tests/port/base.py
> tools/dart/patch_sdk.diff
> 
> That being said, if we must, I'll split this into more digestible pieces on
> Monday.

+ppi

I don't think we should be adding so much Dart-specific stuff to
mojo/public/tools (which already really contains too much). Could it go
somewhere in mojo/devtools instead?

[viettrungluu, 2015-05-15 23:56:29]

viettrungluu@chromium.org changed reviewers:
+ ppi@chromium.org

[abarth-chromium, 2015-05-15 23:56:57]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org
- ppi@chromium.org

[abarth-chromium, 2015-05-15 23:56:58]

sky/sdk/lib/framework/components/drawer.dart

Could this be sky/sdk/lib/components/drawer.dart instead?  The framework part
was always a bit redundant.  We just needed it because otherwise we'd have
spammed the top-level sky directory.

[Cutch, 2015-05-16 00:00:24]

On 2015/05/15 23:56:12, viettrungluu wrote:
> On 2015/05/15 23:49:46, Cutch wrote:
> > On 2015/05/15 23:12:44, eseidel wrote:
> > > This is really big. I wonder if we can't do this in smaller pieces?  Like
> just
> > > the mojo re-org to start...
> > 
> > We could, but, most of this CL is just fall out (file moves and import
> rewrites)
> > from the restructuring. The interesting bits can be found here:
> > 
> > mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl
> > mojo/public/tools/bindings/generators/mojom_dart_generator.py
> > mojo/public/tools/dart_analyze.py
> > mojo/public/tools/dart_list_mojoms.py
> > mojo/public/tools/dart_list_packages_contents.py
> > mojo/public/tools/dart_package.py
> > mojo/public/tools/dart_package_name.py
> > mojo/public/dart/rules.gni
> > mojo/public/tools/dart_pkg.py
> > sky/tools/webkitpy/layout_tests/port/base.py
> > tools/dart/patch_sdk.diff
> > 
> > That being said, if we must, I'll split this into more digestible pieces on
> > Monday.
> 
> +ppi
> 
> I don't think we should be adding so much Dart-specific stuff to
> mojo/public/tools (which already really contains too much). Could it go
> somewhere in mojo/devtools instead?

@viettrungluu: Yes, I'm fine with moving the dart specific bits elsewhere. As a
follow up CL to this one?

[Cutch, 2015-05-16 00:01:46]

On 2015/05/15 23:56:58, abarth wrote:
> sky/sdk/lib/framework/components/drawer.dart
> 
> Could this be sky/sdk/lib/components/drawer.dart instead?  The framework part
> was always a bit redundant.  We just needed it because otherwise we'd have
> spammed the top-level sky directory.

@abarth: Absolutely. In fact, Eric, Ian, and I discussed some other directory
layout changes today. I'd prefer to let the sky team do that surgery after this
CL.

[viettrungluu, 2015-05-16 00:03:45]

On 2015/05/16 00:00:24, Cutch wrote:
> On 2015/05/15 23:56:12, viettrungluu wrote:
> > On 2015/05/15 23:49:46, Cutch wrote:
> > > On 2015/05/15 23:12:44, eseidel wrote:
> > > > This is really big. I wonder if we can't do this in smaller pieces? 
Like
> > just
> > > > the mojo re-org to start...
> > > 
> > > We could, but, most of this CL is just fall out (file moves and import
> > rewrites)
> > > from the restructuring. The interesting bits can be found here:
> > > 
> > > mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl
> > > mojo/public/tools/bindings/generators/mojom_dart_generator.py
> > > mojo/public/tools/dart_analyze.py
> > > mojo/public/tools/dart_list_mojoms.py
> > > mojo/public/tools/dart_list_packages_contents.py
> > > mojo/public/tools/dart_package.py
> > > mojo/public/tools/dart_package_name.py
> > > mojo/public/dart/rules.gni
> > > mojo/public/tools/dart_pkg.py
> > > sky/tools/webkitpy/layout_tests/port/base.py
> > > tools/dart/patch_sdk.diff
> > > 
> > > That being said, if we must, I'll split this into more digestible pieces
on
> > > Monday.
> > 
> > +ppi
> > 
> > I don't think we should be adding so much Dart-specific stuff to
> > mojo/public/tools (which already really contains too much). Could it go
> > somewhere in mojo/devtools instead?
> 
> @viettrungluu: Yes, I'm fine with moving the dart specific bits elsewhere. As
a
> follow up CL to this one?

My preference would be for them to land in the right place to begin with, though
admittedly there's already precedence for mojo/public/tools.... I'll wait for
ppi to weigh in, and defer to his judgment.

[eseidel, 2015-05-18 20:41:39]

Reviewed in person with John.  lgtm

[Cutch, 2015-05-18 21:29:36]

On 2015/05/18 20:41:39, eseidel wrote:
> Reviewed in person with John.  lgtm

Patch Set #4 addresses comments from in person review. A TODO is to move the
dart specific scripts out of mojo/public/tools and into a more appropriate
place.

[eseidel, 2015-05-18 21:34:22]

It took a long time to go through this the first time, I don't plan to go
through it a second. :)  But I appreciate you uploading it for posterity.

[Cutch, 2015-05-18 21:41:50]

Committed patchset #4 (id:60001) manually as
1a396394dd951450f0ff5c2da81dced0ca18e8c8 (presubmit successful).