Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: sky/tools/webkitpy/layout_tests/port/base.py

Issue 1132063007: Rationalize Dart mojo and sky package structure (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tests/services/network.sky ('k') | tools/dart/patch_sdk.diff » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/webkitpy/layout_tests/port/base.py
diff --git a/sky/tools/webkitpy/layout_tests/port/base.py b/sky/tools/webkitpy/layout_tests/port/base.py
index dccb5e14d316be0cd74dfb42d68a48aadd4a2436..169a5e434b1543733bb7f1f652a1e6eee8dcc2c7 100644
--- a/sky/tools/webkitpy/layout_tests/port/base.py
+++ b/sky/tools/webkitpy/layout_tests/port/base.py
@@ -1089,11 +1089,8 @@ class Port(object):
be the case when the tests aren't run on the host platform."""
return True
- def _sky_sdk_path(self):
- return self._build_path('gen/sky_sdk')
-
def _dart_packages_root(self):
- return os.path.join(self._sky_sdk_path(), 'packages_root')
+ return self._build_path('gen/dart-pkg/packages')
def server_command_line(self):
path = (self._options.path_to_server or
@@ -1112,17 +1109,6 @@ class Port(object):
Ports can stub this out if they don't need a web server to be running."""
assert not self._http_server, 'Already running an http server.'
subprocess.call(self.path_to_script('download_sky_server'))
- print # Make blank line before calling deploy_sdk.
- subprocess.call([
- self.path_to_script('deploy_sdk.py'),
- '--build-dir', self._build_path(),
- '--non-interactive',
- '--dev-environment',
- self._sky_sdk_path(),
- '--fake-pub-get-into',
- self._dart_packages_root()
- ])
-
self._http_server = subprocess.Popen(self.server_command_line())
def start_websocket_server(self):
« no previous file with comments | « sky/tests/services/network.sky ('k') | tools/dart/patch_sdk.diff » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698