Ensure that instances of DisplayImpl and SurfaceImpl don't outlive SurfacesServiceApplication.

Ensure that instances of DisplayImpl and SurfaceImpl don't outlive SurfacesServiceApplication.

This is because they have an unowned pointer to cc::SurfaceManager.

Also ensure we don't have a double delete of display_ in DisplayImpl's destructor. This occurred because when display_ was deleted, it would end up calling back into  OutputSurfaceLost() which would attempt to delete display__ again.

This is split off https://codereview.chromium.org/1139673003

BUG=484234
Committed: https://crrev.com/cc43e06f6855d1c34645e498f88d64385f727405
Cr-Commit-Position: refs/heads/master@{#330386}

[jam, 2015-05-18 17:16:24]

jam@chromium.org changed reviewers:
+ erg@chromium.org

[Elliot Glaysher, 2015-05-18 17:41:29]

https://codereview.chromium.org/1131933006/diff/1/components/surfaces/surface...
File components/surfaces/surfaces_service_application.cc (right):

https://codereview.chromium.org/1131933006/diff/1/components/surfaces/surface...
components/surfaces/surfaces_service_application.cc:22:
STLDeleteElements(&displays_);
I suspect that autocomplete went out of control here. Drop the '_'?

[jam, 2015-05-18 17:44:20]

https://codereview.chromium.org/1131933006/diff/1/components/surfaces/surface...
File components/surfaces/surfaces_service_application.cc (right):

https://codereview.chromium.org/1131933006/diff/1/components/surfaces/surface...
components/surfaces/surfaces_service_application.cc:22:
STLDeleteElements(&displays_);
On 2015/05/18 17:41:29, Elliot Glaysher wrote:
> I suspect that autocomplete went out of control here. Drop the '_'?

oops, fixed, thanks.

[Elliot Glaysher, 2015-05-18 17:44:58]

lgtm

[jam, 2015-05-18 17:45:02]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-05-18 17:45:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131933006/20001

[commit-bot: I haz the power, 2015-05-18 20:13:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-18 22:41:11]

Patchset 2 (id:??) landed as
https://crrev.com/cc43e06f6855d1c34645e498f88d64385f727405
Cr-Commit-Position: refs/heads/master@{#330386}