Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: components/surfaces/display_factory_impl.cc

Issue 1131933006: Ensure that instances of DisplayImpl and SurfaceImpl don't outlive SurfacesServiceApplication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/surfaces/display_factory_impl.h ('k') | components/surfaces/display_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/surfaces/display_factory_impl.cc
diff --git a/components/surfaces/display_factory_impl.cc b/components/surfaces/display_factory_impl.cc
index fa7a5a8d4683c4f4175bc6ab3b646beabe9f4846..29433708c8e09695ace6259dc894644d08e48c2c 100644
--- a/components/surfaces/display_factory_impl.cc
+++ b/components/surfaces/display_factory_impl.cc
@@ -9,12 +9,14 @@
namespace surfaces {
DisplayFactoryImpl::DisplayFactoryImpl(
+ SurfacesServiceApplication* application,
cc::SurfaceManager* manager,
uint32_t id_namespace,
SurfacesScheduler* scheduler,
mojo::InterfaceRequest<mojo::DisplayFactory> request)
: id_namespace_(id_namespace),
next_local_id_(1u),
+ application_(application),
scheduler_(scheduler),
manager_(manager),
binding_(this, request.Pass()) {
@@ -29,8 +31,9 @@ void DisplayFactoryImpl::Create(
mojo::InterfaceRequest<mojo::Display> display_request) {
cc::SurfaceId cc_id(static_cast<uint64_t>(id_namespace_) << 32 |
next_local_id_++);
- new DisplayImpl(manager_, cc_id, scheduler_, context_provider.Pass(),
- returner.Pass(), display_request.Pass());
+ new DisplayImpl(application_, manager_, cc_id, scheduler_,
+ context_provider.Pass(), returner.Pass(),
+ display_request.Pass());
}
} // namespace surfaces
« no previous file with comments | « components/surfaces/display_factory_impl.h ('k') | components/surfaces/display_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698